Issue 219013004: Revert of [DevTools] Don't handle shortcuts while dialog is open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 219013004: Revert of [DevTools] Don't handle shortcuts while dialog is open. (Closed)

Created:
6 years, 8 months ago by dgozman

Modified:
6 years, 8 months ago

Reviewers:
apavlov

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Revert of [DevTools] Don't handle shortcuts while dialog is open. (https://codereview.chromium.org/214453003/) Reason for revert: We should still intercept browser shortcuts, even with dialog open. Original issue's description: > [DevTools] Don't handle shortcuts while dialog is open. > > BUG=356616 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170294 TBR=apavlov@chromium.org NOTREECHECKS=true NOTRY=true BUG=356616 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170436

Patch Set 1 #

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+1 line, -5 lines)			Patch
M	Source/devtools/front_end/Dialog.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/InspectorView.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/Main.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgozman

Created Revert of [DevTools] Don't handle shortcuts while dialog is open.

6 years, 8 months ago (2014-03-31 10:11:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/219013004/1

6 years, 8 months ago (2014-03-31 10:11:32 UTC) #2

Message was sent while issue was closed.

Change committed as 170436

Expand Messages | Collapse Messages