core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h - Issue 2190123002: Fixup crypto key generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h

Issue 2190123002: Fixup crypto key generation. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Key helper Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h

diff --git a/core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h b/core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h

index 3edc47b7b01f248bd65ac80166d767018ce4cd6b..c98a666bd9ac52c0350cbb14390709e2822db7ba 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h

+++ b/core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h

@@ -62,6 +62,9 @@ class CPDF_CryptoHandler {

int m_KeyLen;

int m_Cipher;

uint8_t* m_pAESContext;

+ private:

+ void PopulateKey(uint8_t* key, uint32_t objnum, uint32_t gennum);

Tom Sepez 2016/07/28 20:56:58 super-nit: out parameters should go last.

dsinclair 2016/08/02 17:34:26 Done.

};

#endif // CORE_FPDFAPI_FPDF_PARSER_CPDF_CRYPTO_HANDLER_H_

« no previous file with comments | « no previous file | core/fpdfapi/fpdf_parser/cpdf_crypto_handler.cpp » ('j') | no next file with comments »