Fixup crypto key generation.

Fixup crypto key generation.

This CL fixes up the crypto key copying code to better handle big endian
machines.

BUG=pdfium:147
Committed: https://pdfium.googlesource.com/pdfium/+/0690c35fec9c320bdc69b4a8678677fe143cee54

[dsinclair, 2016-07-28 20:38:18]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 20:38:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-07-28 20:40:25]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org

[dsinclair, 2016-07-28 20:40:25]

PTAL.

I went back through the history, but the weird merge has been in there since we
got the code drop, so possibly a bad merge from pre-pdfium.

[Tom Sepez, 2016-07-28 20:46:22]

https://codereview.chromium.org/2190123002/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_crypto_handler.cpp (right):

https://codereview.chromium.org/2190123002/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_crypto_handler.cpp:30: uint8_t key1[32];
can we pull this into a helper function?

[dsinclair, 2016-07-28 20:55:23]

https://codereview.chromium.org/2190123002/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_crypto_handler.cpp (right):

https://codereview.chromium.org/2190123002/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_crypto_handler.cpp:30: uint8_t key1[32];
On 2016/07/28 20:46:22, Tom Sepez wrote:
> can we pull this into a helper function?

Done.

[Tom Sepez, 2016-07-28 20:56:59]

lgtm

https://codereview.chromium.org/2190123002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h (right):

https://codereview.chromium.org/2190123002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h:67: void PopulateKey(uint8_t*
key, uint32_t objnum, uint32_t gennum);
super-nit: out parameters should go last.

[dsinclair, 2016-08-02 17:34:26]

https://codereview.chromium.org/2190123002/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h (right):

https://codereview.chromium.org/2190123002/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_crypto_handler.h:67: void PopulateKey(uint8_t*
key, uint32_t objnum, uint32_t gennum);
On 2016/07/28 20:56:58, Tom Sepez wrote:
> super-nit: out parameters should go last.

Done.

[dsinclair, 2016-08-02 17:34:29]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-02 17:34:29]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2190123002/#ps40001
(title: "Out param last")

[commit-bot: I haz the power, 2016-08-02 17:34:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:48:33]

Description was changed from

==========
Fixup crypto key generation.

This CL fixes up the crypto key copying code to better handle big endian
machines.

BUG=pdfium:147
==========

to

==========
Fixup crypto key generation.

This CL fixes up the crypto key copying code to better handle big endian
machines.

BUG=pdfium:147

Committed:
https://pdfium.googlesource.com/pdfium/+/0690c35fec9c320bdc69b4a8678677fe143c...
==========

[commit-bot: I haz the power, 2016-08-02 17:48:34]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/0690c35fec9c320bdc69b4a8678677fe143c...