Delete image-based rebaselining tool; we have switched to checksums

Delete image-based rebaselining tool; we have switched to checksums

R=borenet@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10524

[epoger, 2013-08-02 20:26:49]

https://codereview.chromium.org/21901004/diff/1/tools/rebaseline.py
File tools/rebaseline.py (left):

https://codereview.chromium.org/21901004/diff/1/tools/rebaseline.py#oldcode13
tools/rebaseline.py:13: TODO(epoger): Fix indentation in this file (2-space
indents, not 4-space).
Patchset 1 just fixes the indentation in this file (2-space indents, not
4-space).  Self-tests still pass with no changes.

[epoger, 2013-08-02 20:38:29]

first LG wins...

[borenet, 2013-08-02 20:49:19]

LGTM with question.

https://codereview.chromium.org/21901004/diff/4001/tools/rebaseline.py
File tools/rebaseline.py (left):

https://codereview.chromium.org/21901004/diff/4001/tools/rebaseline.py#oldcod...
tools/rebaseline.py:392: missing_json_is_fatal=missing_json_is_fatal)
A quick skim suggests that, outside of the above block, the changes in this file
are just whitespace.  Is that correct?

[epoger, 2013-08-02 20:52:42]

On 2013/08/02 20:49:19, borenet wrote:
> LGTM with question.
> 
> https://codereview.chromium.org/21901004/diff/4001/tools/rebaseline.py
> File tools/rebaseline.py (left):
> 
>
https://codereview.chromium.org/21901004/diff/4001/tools/rebaseline.py#oldcod...
> tools/rebaseline.py:392: missing_json_is_fatal=missing_json_is_fatal)
> A quick skim suggests that, outside of the above block, the changes in this
file
> are just whitespace.  Is that correct?

Pretty much.  The change was staged as follows:

- Patchset 1: fix indentation levels in rebaseline.py
https://codereview.chromium.org/21901004/diff/1/tools/rebaseline.py

- Patchset 2: remove image-based rebaselining code
https://codereview.chromium.org/21901004/diff2/1:4001/tools/rebaseline.py

Sorry for not making that clearer.

[borenet, 2013-08-02 20:54:04]

On 2013/08/02 20:52:42, epoger wrote:
> On 2013/08/02 20:49:19, borenet wrote:
> > LGTM with question.
> > 
> > https://codereview.chromium.org/21901004/diff/4001/tools/rebaseline.py
> > File tools/rebaseline.py (left):
> > 
> >
>
https://codereview.chromium.org/21901004/diff/4001/tools/rebaseline.py#oldcod...
> > tools/rebaseline.py:392: missing_json_is_fatal=missing_json_is_fatal)
> > A quick skim suggests that, outside of the above block, the changes in this
> file
> > are just whitespace.  Is that correct?
> 
> Pretty much.  The change was staged as follows:
> 
> - Patchset 1: fix indentation levels in rebaseline.py
> https://codereview.chromium.org/21901004/diff/1/tools/rebaseline.py
> 
> - Patchset 2: remove image-based rebaselining code
> https://codereview.chromium.org/21901004/diff2/1:4001/tools/rebaseline.py
> 
> Sorry for not making that clearer.

Great. LGTM

[epoger, 2013-08-02 20:54:49]

Committed patchset #2 manually as r10524 (presubmit successful).

[Stephen White, 2013-08-05 13:53:21]

On 2013/08/02 20:54:49, epoger wrote:
> Committed patchset #2 manually as r10524 (presubmit successful).

I'm a weekend late on this but LGTM too. I love it when code goes away!