Chromium Code Reviews

Unified Diff: Source/bindings/v8/WorkerScriptController.cpp

Issue 219003002: [ABANDONED] Call Microtask::performCheckpoint for each worker task. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Call ensureDomInJSContext Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | Source/core/workers/WorkerRunLoop.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/WorkerScriptController.cpp
diff --git a/Source/bindings/v8/WorkerScriptController.cpp b/Source/bindings/v8/WorkerScriptController.cpp
index 6127764871bf72ad64238da0085237b601cbcfd7..65369afd5e6ab93f156024a6253cf8620173e0d8 100644
--- a/Source/bindings/v8/WorkerScriptController.cpp
+++ b/Source/bindings/v8/WorkerScriptController.cpp
@@ -70,6 +70,13 @@ WorkerScriptController::WorkerScriptController(WorkerGlobalScope& workerGlobalSc
V8PerIsolateData::ensureInitialized(m_isolate);
m_world = DOMWrapperWorld::create(WorkerWorldId);
m_interruptor = adoptPtr(new V8IsolateInterruptor(m_isolate));
+
+ // FIXME: Calling v8::Context::New in ensureDomInJsContext() later may
adamk 2014/03/31 15:27:37 What circumstances? What do the crashes look like
+ // fail in certain cases and lead to a crash.
+ // We need these statements here to prevent that.
+ v8::HandleScope handleScope(m_isolate);
+ V8PerIsolateData::from(m_isolate)->ensureDomInJSContext();
+
ThreadState::current()->addInterruptor(m_interruptor.get());
}
« no previous file with comments | « no previous file | Source/core/workers/WorkerRunLoop.cpp » ('j') | no next file with comments »

Powered by Google App Engine