Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2189983002: Make both SK_API definition points identical and order independent. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make both SK_API definition points identical and order independent. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189983002 Committed: https://skia.googlesource.com/skia/+/fa84d94bb0b226f81b7eaa411aabbbaec3d180cb

Patch Set 1 #

Patch Set 2 : TODOne #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
M include/c/sk_types.h View 1 chunk +14 lines, -2 lines 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mtklein_C
This is an alternative to the other CL that included SkPreConfig.h into sk_types.h
4 years, 4 months ago (2016-07-28 15:53:59 UTC) #7
reed1
lgtm
4 years, 4 months ago (2016-07-28 16:05:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189983002/20001
4 years, 4 months ago (2016-07-28 16:14:39 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 16:45:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fa84d94bb0b226f81b7eaa411aabbbaec3d180cb

Powered by Google App Engine
This is Rietveld 408576698