Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2189963002: Comment out some infobar identifiers for obsolete infobars. (Closed)

Created:
4 years, 4 months ago by Evan Stade
Modified:
4 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Comment out some infobar identifiers for obsolete infobars. BUG=none Committed: https://crrev.com/c283644ddac0839170780ef5e3c78798db5b293b Cr-Commit-Position: refs/heads/master@{#408454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/infobars/core/infobar_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Evan Stade
4 years, 4 months ago (2016-07-28 14:38:51 UTC) #3
Peter Kasting
LGTM
4 years, 4 months ago (2016-07-28 18:14:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189963002/1
4 years, 4 months ago (2016-07-28 19:32:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 19:36:33 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c283644ddac0839170780ef5e3c78798db5b293b Cr-Commit-Position: refs/heads/master@{#408454}
4 years, 4 months ago (2016-07-28 19:38:19 UTC) #12
jif
4 years, 4 months ago (2016-07-29 09:04:44 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2193773002/ by jif@chromium.org.

The reason for reverting is: Very sorry to revert this, but both
READER_MODE_INFOBAR_DELEGATE and UPGRADE_INFOBAR_DELEGATE are still used by
Chrome iOS..

Powered by Google App Engine
This is Rietveld 408576698