Make MultipartRequest more closely adhere to browsers' behavior.

pkg/http/test/multipart_test.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library multipart_test;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
 
@@ skipping 75 matching lines @@
         --{{boundary}}--
         '''));
   });
 
   test('with a unicode field name', () {
     var request = new http.MultipartRequest('POST', dummyUrl);
     request.fields['fïēld'] = 'value';
 
     expect(request, bodyMatches('''
         --{{boundary}}
-        content-disposition: form-data; name="f%C3%AF%C4%93ld"
+        content-disposition: form-data; name="fïēld"
 
         value
         --{{boundary}}--
+        '''));
+  });
+
+  test('with a field name with newlines', () {
+    var request = new http.MultipartRequest('POST', dummyUrl);
+    request.fields['foo\nbar\rbaz\r\nbang'] = 'value';
+
+    expect(request, bodyMatches('''
+        --{{boundary}}
+        content-disposition: form-data; name="foo%0D%0Abar%0D%0Abaz%0D%0Abang"
+
+        value
+        --{{boundary}}--
+        '''));
+  });
+
+  test('with a field name with a quote', () {
+    var request = new http.MultipartRequest('POST', dummyUrl);
+    request.fields['foo"bar'] = 'value';
+
+    expect(request, bodyMatches('''
+        --{{boundary}}
+        content-disposition: form-data; name="foo%22bar"

[Bob Nystrom, 2014/04/01 19:45:26]

Is it worth also testing that a single quote *isn't* encoded?

[nweiz, 2014/04/02 01:09:44]

I don't think so. There's nothing special about a single quote anywhere in HTTP.

+
+        value
+        --{{boundary}}--
         '''));
   });
 
   test('with a unicode field value', () {
     var request = new http.MultipartRequest('POST', dummyUrl);
     request.fields['field'] = 'vⱥlūe';
 
     expect(request, bodyMatches('''
         --{{boundary}}
         content-disposition: form-data; name="field"
         content-type: text/plain; charset=utf-8
 
         vⱥlūe
         --{{boundary}}--
         '''));
   });
 
   test('with a unicode filename', () {
     var request = new http.MultipartRequest('POST', dummyUrl);
     request.files.add(new http.MultipartFile.fromString('file', 'contents',
         filename: 'fïlēname.txt'));
 
     expect(request, bodyMatches('''
         --{{boundary}}
         content-type: text/plain; charset=utf-8
-        content-disposition: form-data; name="file"; filename="f%C3%AFl%C4%93name.txt"
+        content-disposition: form-data; name="file"; filename="fïlēname.txt"
 
         contents
         --{{boundary}}--
+        '''));
+  });
+
+  test('with a filename with newlines', () {
+    var request = new http.MultipartRequest('POST', dummyUrl);
+    request.files.add(new http.MultipartFile.fromString('file', 'contents',
+        filename: 'foo\nbar\rbaz\r\nbang'));
+
+    expect(request, bodyMatches('''
+        --{{boundary}}
+        content-type: text/plain; charset=utf-8
+        content-disposition: form-data; name="file"; filename="foo%0D%0Abar%0D%0Abaz%0D%0Abang"
+
+        contents
+        --{{boundary}}--
+        '''));
+  });
+
+  test('with a filename with a quote', () {
+    var request = new http.MultipartRequest('POST', dummyUrl);
+    request.files.add(new http.MultipartFile.fromString('file', 'contents',
+        filename: 'foo"bar'));
+
+    expect(request, bodyMatches('''
+        --{{boundary}}
+        content-type: text/plain; charset=utf-8
+        content-disposition: form-data; name="file"; filename="foo%22bar"
+
+        contents
+        --{{boundary}}--
         '''));
   });
 
   test('with a string file with a content-type but no charset', () {
     var request = new http.MultipartRequest('POST', dummyUrl);
     var file = new http.MultipartFile.fromString('file', '{"hello": "world"}',
         contentType: new ContentType('application', 'json'));
     request.files.add(file);
 
     expect(request, bodyMatches('''
@@ skipping 96 matching lines @@
         content-type: application/octet-stream
         content-disposition: form-data; name="file"; filename="test-file"
 
         hello
         --{{boundary}}--
         '''));
       }), completes);
     });
   });
 }