Call currently unimplemented history shims on WebView

Call currently unimplemented history shims on WebView

This is step 2 of 5 in moving HistoryController to content/, as described in http://crbug.com/357327

These calls will allow content/ to be responsible for updating history state in step 3, and eventually to implement history state management in step 4.

BUG=357327
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261458

[Charlie Reis, 2014-04-02 17:52:59]

LGTM with nits and one running question about WebView vs WebFrame.  If that's
just a temporary thing while we move the code, then I'm not concerned.

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:1412: return
render_view_->webview()->itemForNewChildFrame(frame);
Should this be on WebFrame rather than WebView?

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:1525:
render_view_->webview()->removeChildrenForRedirect(frame);
Just curious, why is this on the WebView rather than WebFrame, if it's specific
to a frame?

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:1647: void
RenderFrameImpl::didCommitProvisionalLoad(blink::WebFrame* frame,
nit: frame should be on its own line, aligned with the others.

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:1652:
render_view_->webview()->updateForCommit(frame, item, commit_type,
updateForCommit should also be on WebFrame rather than WebView.  Are these just
temporary steps while we move this into content?

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:1909: 
nit: No extra line here.

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.h:255: const blink::WebHistoryItem& item,
nit: Wrong indent.

[Nate Chapin, 2014-04-02 17:58:35]

Re: WebFrame vs WebView, yes, all those are temporary functions to make the
transition work. I chose WebView over WebFrame mostly to represent how the API
works currently, where HistoryController is owned by the Page.

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:1647: void
RenderFrameImpl::didCommitProvisionalLoad(blink::WebFrame* frame,
On 2014/04/02 17:52:59, Charlie Reis wrote:
> nit: frame should be on its own line, aligned with the others.

Done.

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.cc:1909: 
On 2014/04/02 17:52:59, Charlie Reis wrote:
> nit: No extra line here.

Done.

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/218993014/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.h:255: const blink::WebHistoryItem& item,
On 2014/04/02 17:52:59, Charlie Reis wrote:
> nit: Wrong indent.

Done.

[Nate Chapin, 2014-04-02 17:59:32]

The CQ bit was checked by japhet@chromium.org

[Charlie Reis, 2014-04-02 18:00:12]

Thanks, sounds good.  LGTM with nit.

https://codereview.chromium.org/218993014/diff/20001/content/renderer/render_...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/218993014/diff/20001/content/renderer/render_...
content/renderer/render_frame_impl.h:254: virtual void
didCommitProvisionalLoad(blink::WebFrame* frame,
nit: This goes on the next line.

[commit-bot: I haz the power, 2014-04-02 18:01:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/218993014/20001

[Nate Chapin, 2014-04-02 18:15:10]

The CQ bit was unchecked by japhet@chromium.org

[Nate Chapin, 2014-04-02 18:15:28]

On 2014/04/02 18:00:12, Charlie Reis wrote:
> Thanks, sounds good.  LGTM with nit.
> 
>
https://codereview.chromium.org/218993014/diff/20001/content/renderer/render_...
> File content/renderer/render_frame_impl.h (right):
> 
>
https://codereview.chromium.org/218993014/diff/20001/content/renderer/render_...
> content/renderer/render_frame_impl.h:254: virtual void
> didCommitProvisionalLoad(blink::WebFrame* frame,
> nit: This goes on the next line.

Thanks. I am bad at chromium style.

[Nate Chapin, 2014-04-02 18:16:13]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-04-02 18:17:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/218993014/40001

[commit-bot: I haz the power, 2014-04-03 05:55:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-03 05:55:29]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_chromeos_rel

[Nate Chapin, 2014-04-03 16:07:24]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-04-03 16:07:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/218993014/40001

[commit-bot: I haz the power, 2014-04-03 17:12:53]

Change committed as 261458