src/objects.cc - Issue 218993011: Remove internalized cons string types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 218993011: Remove internalized cons string types. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 92ec283350fd515c9aa7f46ecb3a41fd79b097b1..8f2b26ec8f2b4f778da644b6f4964072461e57da 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -13872,9 +13872,6 @@ class InternalizedStringKey : public HashTableKey {

}

MaybeObject* AsObject(Heap* heap) {

- // Attempt to flatten the string, so that internalized strings will most

- // often be flat strings.

- string_ = string_->TryFlattenGetString();

Michael Starzinger 2014/04/01 10:55:18 I am not an expert on this, but doesn't it still m

// Internalize the string if possible.

Map* map = heap->InternalizedStringMapForString(string_);

if (map != NULL) {

« no previous file with comments | « src/objects.h ('k') | src/types.cc » ('j') | no next file with comments »