Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 218993009: Use CheckCallAndFilterAndHeader for git commands. (Closed)

Created:
6 years, 8 months ago by agable
Modified:
6 years, 8 months ago
Reviewers:
Vadim Sh., iannucci, szager1
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Use CheckCallAndFilterAndHeader for git commands. This causes git commands to be completely silent (they don't even print ______ running 'git foo bar') if the git command itself is completely silent. This mirrors the behavior of SVN commands. This is useful for commands like 'gclient diff', which should print no output at all if there is no diff. R=szager@chromium.org, vadimsh@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=260758

Patch Set 1 #

Patch Set 2 : Fix test cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -71 lines) Patch
M gclient_scm.py View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/gclient_smoketest.py View 1 16 chunks +25 lines, -67 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
agable
6 years, 8 months ago (2014-04-01 01:14:05 UTC) #1
iannucci
*sigh* lgtm
6 years, 8 months ago (2014-04-01 02:29:00 UTC) #2
agable
Stefan: landing this is necessary for switching the commit queue to git. There are other ...
6 years, 8 months ago (2014-04-01 02:33:41 UTC) #3
agable
The CQ bit was checked by agable@chromium.org
6 years, 8 months ago (2014-04-01 02:33:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agable@chromium.org/218993009/20001
6 years, 8 months ago (2014-04-01 02:33:55 UTC) #5
commit-bot: I haz the power
Change committed as 260758
6 years, 8 months ago (2014-04-01 02:35:45 UTC) #6
szager1
6 years, 8 months ago (2014-04-02 17:19:45 UTC) #7
Message was sent while issue was closed.
lgtm, I always hated that terminal spew.

Powered by Google App Engine
This is Rietveld 408576698