Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 218993005: Tighten object verification. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Tighten object verification. Often, when we call MaybeObject::Verify, what we want is Object::ObjectVerify. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M src/api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-debug.cc View 6 chunks +17 lines, -16 lines 0 comments Download
M src/spaces.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 8 months ago (2014-03-31 14:06:17 UTC) #1
Hannes Payer (out of office)
lgtm
6 years, 8 months ago (2014-04-01 08:31:52 UTC) #2
Yang
6 years, 8 months ago (2014-04-01 08:58:00 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20382 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698