Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: services/ui/ws/platform_display.h

Issue 2189893004: Unify display ids between Display and PlatformDisplay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Back to pure virtual. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/ui/ws/display_manager.cc ('k') | services/ui/ws/platform_display.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/ui/ws/platform_display.h
diff --git a/services/ui/ws/platform_display.h b/services/ui/ws/platform_display.h
index d7bc2f6033afbc69c355d9835c2638b4eff30fb3..8658536dd6e51f1f50126c1bb2b3de9908ffb4a9 100644
--- a/services/ui/ws/platform_display.h
+++ b/services/ui/ws/platform_display.h
@@ -56,6 +56,8 @@ class PlatformDisplay {
static PlatformDisplay* Create(const PlatformDisplayInitParams& init_params);
+ virtual int64_t GetId() const = 0;
+
virtual void Init(PlatformDisplayDelegate* delegate) = 0;
// Schedules a paint for the specified region in the coordinates of |window|.
@@ -85,8 +87,6 @@ class PlatformDisplay {
virtual void RequestCopyOfOutput(
std::unique_ptr<cc::CopyOutputRequest> output_request) = 0;
- virtual int64_t GetDisplayId() const = 0;
-
virtual gfx::Rect GetBounds() const = 0;
// Overrides factory for testing. Default (NULL) value indicates regular
@@ -111,6 +111,7 @@ class DefaultPlatformDisplay : public PlatformDisplay,
// PlatformDisplay:
void Init(PlatformDisplayDelegate* delegate) override;
+ int64_t GetId() const override;
void SchedulePaint(const ServerWindow* window,
const gfx::Rect& bounds) override;
void SetViewportSize(const gfx::Size& size) override;
@@ -125,7 +126,6 @@ class DefaultPlatformDisplay : public PlatformDisplay,
bool IsFramePending() const override;
void RequestCopyOfOutput(
std::unique_ptr<cc::CopyOutputRequest> output_request) override;
- int64_t GetDisplayId() const override;
gfx::Rect GetBounds() const override;
private:
@@ -150,7 +150,7 @@ class DefaultPlatformDisplay : public PlatformDisplay,
bool IsInHighContrastMode() override;
const ViewportMetrics& GetViewportMetrics() override;
- int64_t display_id_;
+ int64_t id_;
#if !defined(OS_ANDROID)
std::unique_ptr<ui::CursorLoader> cursor_loader_;
« no previous file with comments | « services/ui/ws/display_manager.cc ('k') | services/ui/ws/platform_display.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698