Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2321)

Unified Diff: services/ui/ws/test_utils.cc

Issue 2189893004: Unify display ids between Display and PlatformDisplay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move id into PlatformDisplay and fix tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/test_utils.cc
diff --git a/services/ui/ws/test_utils.cc b/services/ui/ws/test_utils.cc
index 795954c86a95926fc5f43362cb8633b39560126e..189f1f229f09fae9635e19e657bec3ac89321dbf 100644
--- a/services/ui/ws/test_utils.cc
+++ b/services/ui/ws/test_utils.cc
@@ -27,8 +27,8 @@ namespace {
// Empty implementation of PlatformDisplay.
class TestPlatformDisplay : public PlatformDisplay {
public:
- explicit TestPlatformDisplay(int32_t* cursor_id_storage)
- : cursor_id_storage_(cursor_id_storage) {
+ explicit TestPlatformDisplay(int64_t id, int32_t* cursor_id_storage)
+ : PlatformDisplay(id), cursor_id_storage_(cursor_id_storage) {
display_metrics_.bounds = gfx::Rect(0, 0, 400, 300);
display_metrics_.device_scale_factor = 1.f;
}
@@ -59,7 +59,6 @@ class TestPlatformDisplay : public PlatformDisplay {
bool IsFramePending() const override { return false; }
void RequestCopyOfOutput(
std::unique_ptr<cc::CopyOutputRequest> output_request) override {}
- int64_t GetDisplayId() const override { return 1; }
gfx::Rect GetBounds() const override { return display_metrics_.bounds; }
private:
@@ -110,7 +109,7 @@ TestPlatformDisplayFactory::TestPlatformDisplayFactory(
TestPlatformDisplayFactory::~TestPlatformDisplayFactory() {}
PlatformDisplay* TestPlatformDisplayFactory::CreatePlatformDisplay() {
- return new TestPlatformDisplay(cursor_id_storage_);
+ return new TestPlatformDisplay(next_display_id++, cursor_id_storage_);
}
// TestFrameGeneratorDelegate -------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698