Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: services/ui/ws/platform_display.cc

Issue 2189893004: Unify display ids between Display and PlatformDisplay. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move id into PlatformDisplay and fix tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/platform_display.cc
diff --git a/services/ui/ws/platform_display.cc b/services/ui/ws/platform_display.cc
index e0fbdafa999eac6618244d2bea625260f8b71363..1939f21fcbfcf8d802166ffb8f736f0319ce19f4 100644
--- a/services/ui/ws/platform_display.cc
+++ b/services/ui/ws/platform_display.cc
@@ -43,6 +43,8 @@ namespace ws {
// static
PlatformDisplayFactory* PlatformDisplay::factory_ = nullptr;
+PlatformDisplay::PlatformDisplay(int64_t id) : id_(id) {}
+
// static
PlatformDisplay* PlatformDisplay::Create(
const PlatformDisplayInitParams& init_params) {
@@ -54,12 +56,11 @@ PlatformDisplay* PlatformDisplay::Create(
DefaultPlatformDisplay::DefaultPlatformDisplay(
const PlatformDisplayInitParams& init_params)
- : display_id_(init_params.display_id),
+ : PlatformDisplay(init_params.display_id),
#if !defined(OS_ANDROID)
cursor_loader_(ui::CursorLoader::Create()),
#endif
- frame_generator_(new FrameGenerator(this,
- init_params.surfaces_state)) {
+ frame_generator_(new FrameGenerator(this, init_params.surfaces_state)) {
metrics_.bounds = init_params.display_bounds;
// TODO(rjkroege): Preserve the display_id when Ozone platform can use it.
}
@@ -161,10 +162,6 @@ bool DefaultPlatformDisplay::IsFramePending() const {
return frame_generator_->is_frame_pending();
}
-int64_t DefaultPlatformDisplay::GetDisplayId() const {
- return display_id_;
-}
-
gfx::Rect DefaultPlatformDisplay::GetBounds() const {
return metrics_.bounds;
}

Powered by Google App Engine
This is Rietveld 408576698