cc/animation/element_animations.h - Issue 2189813002: ElementAnimations should hold an ObservableList of AnimationPlayers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/element_animations.h

Issue 2189813002: ElementAnimations should hold an ObservableList of AnimationPlayers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix windows bot Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/animation/element_animations.h

diff --git a/cc/animation/element_animations.h b/cc/animation/element_animations.h

index a46560450b27038a547b6c5ded9651837769ef14..93f4f0e9f0d516ebcad6ed1284aec34dcdb4d677 100644

--- a/cc/animation/element_animations.h

+++ b/cc/animation/element_animations.h

@@ -9,9 +9,9 @@

#include <memory>

#include <vector>

-#include "base/containers/linked_list.h"

#include "base/macros.h"

#include "base/memory/ref_counted.h"

+#include "base/observer_list.h"

#include "base/time/time.h"

#include "cc/animation/animation.h"

#include "cc/animation/animation_curve.h"

@@ -62,9 +62,8 @@ class CC_EXPORT ElementAnimations : public base::RefCounted<ElementAnimations> {

void RemovePlayer(AnimationPlayer* player);

bool IsEmpty() const;

- typedef base::LinkedList<AnimationPlayer> PlayersList;

- typedef base::LinkNode<AnimationPlayer> PlayersListNode;

- const PlayersList& players_list() const { return *players_list_.get(); }

+ typedef base::ObserverList<AnimationPlayer> PlayersList;

+ PlayersList& players_list() const { return *players_list_.get(); }

// Ensures that the list of active animations on the main thread and the impl

// thread are kept in sync. This function does not take ownership of the impl

« no previous file with comments | « cc/animation/animation_player.h ('k') | cc/animation/element_animations.cc » ('j') | no next file with comments »