Issue 21898008: Revert 215407 "Base: FileEnumerator should not follow reparse po..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21898008: Revert 215407 "Base: FileEnumerator should not follow reparse po..." (Closed)

Created:
7 years, 4 months ago by rvargas (doing something else)

Modified:
7 years, 4 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 215407 "Base: FileEnumerator should not follow reparse po..." > Base: FileEnumerator should not follow reparse points. > > Following reparse points by default is dangerous because it can easily result > in infinite loops. > > BUG=260360 > TEST=base_unittests > > Review URL: https://chromiumcodereview.appspot.com/20610004 TBR=rvargas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215443

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -134 lines)			Patch
	M	trunk/src/base/file_util_unittest.cc	View		6 chunks	+90 lines, -130 lines	0 comments	Download
	M	trunk/src/base/files/file_enumerator_win.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

rvargas (doing something else)

7 years, 4 months ago (2013-08-03 01:37:18 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r215443.