Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 2189783002: Record names of classes which unnamed constructor are used in SuperConstructorInvocation. (Closed)

Created:
4 years, 4 months ago by scheglov
Modified:
4 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Record names of classes which unnamed constructor are used in SuperConstructorInvocation. So, if the unnamed constructor is changed, we can invalidate resolution. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/491775e1cce92a40a8d34e6046cd89dbfcdca399

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -2 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 6 chunks +38 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 4 chunks +88 lines, -2 lines 1 comment Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 4 months ago (2016-07-27 21:55:52 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2189783002/diff/1/pkg/analyzer/test/src/context/context_test.dart File pkg/analyzer/test/src/context/context_test.dart (right): https://codereview.chromium.org/2189783002/diff/1/pkg/analyzer/test/src/context/context_test.dart#newcode2947 pkg/analyzer/test/src/context/context_test.dart:2947: // inherited unimplemented members. This seems like the ...
4 years, 4 months ago (2016-07-27 22:09:33 UTC) #2
scheglov
4 years, 4 months ago (2016-07-28 15:27:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
491775e1cce92a40a8d34e6046cd89dbfcdca399 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698