Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2189773002:
[Android] Set platform mode as default for perf tests. (Closed)
|
Created:
4 years, 4 months ago by rnephew (Reviews Here) Modified:
4 years, 4 months ago CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Android] Set platform mode as default for perf tests.
BUG=615157
Committed: https://crrev.com/9ea896bb6a840dcf84381fea4fece6069d497159
Cr-Commit-Position: refs/heads/master@{#408665}
Patch Set 1 #
Messages
Total messages: 17 (5 generated)
rnephew@chromium.org changed reviewers: + jbudorick@chromium.org, mikecase@chromium.org
Bots currently running in platform mode: https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20P... https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20P... https://build.chromium.org/p/chromium.perf/builders/Android%20Galaxy%20S5%20P... None of the failures on those bots appear to be related to platform mode.
Hold this until tomorrow, at least.
On 2016/07/27 21:43:46, jbudorick wrote: > Hold this until tomorrow, at least. Yeah, I didn't plan on landing this today; just getting it ready.
On 2016/07/27 21:44:07, rnephew (Reviews Here) wrote: > On 2016/07/27 21:43:46, jbudorick wrote: > > Hold this until tomorrow, at least. > > Yeah, I didn't plan on landing this today; just getting it ready. ping.
lgtm. Good luck
lgtm. Please warn the perf folks.
The CQ bit was checked by rnephew@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by rnephew@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Android] Set platform mode as default for perf tests. BUG=615157 ========== to ========== [Android] Set platform mode as default for perf tests. BUG=615157 Committed: https://crrev.com/9ea896bb6a840dcf84381fea4fece6069d497159 Cr-Commit-Position: refs/heads/master@{#408665} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9ea896bb6a840dcf84381fea4fece6069d497159 Cr-Commit-Position: refs/heads/master@{#408665}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2201563002/ by rnephew@chromium.org. The reason for reverting is: https://bugs.chromium.org/p/chromium/issues/detail?id=632922. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
