Landing Recent QUIC changes until 7/26/2016 13:53 UTC

Landing Recent QUIC changes until 7/26/2016 13:53 UTC

Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.  These stats are not yet populated.

Merge internal change: 128466946
https://codereview.chromium.org/2188663003/

Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519
https://codereview.chromium.org/2192633002/

Add a new flag to require QUIC handshake confirmation, but only for versions before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128
https://codereview.chromium.org/2187463004/

Ignore RTT measurements greater than 30 seconds in QUIC and limit the LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078
https://codereview.chromium.org/2185163002/

Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346
https://codereview.chromium.org/2192623002/

Committed: https://crrev.com/f90f8dc2cb4c31a11da888eaf267aba1d6e409cd
Cr-Commit-Position: refs/heads/master@{#408274}

[Ryan Hamilton, 2016-07-27 21:31:43]

Description was changed from

==========
Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.
 These stats are not yet populated.

Merge internal change: 128466946

Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK
frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519

Add a new flag to require QUIC handshake confirmation, but only for versions
before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128

Ignore RTT measurements greater than 30 seconds in QUIC and limit the
LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078

Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346

BUG=
==========

to

==========
Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.
 These stats are not yet populated.

Merge internal change: 128466946
https://codereview.chromium.org/2188663003/


Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK
frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519
https://codereview.chromium.org/2192633002/


Add a new flag to require QUIC handshake confirmation, but only for versions
before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128
https://codereview.chromium.org/2187463004/


Ignore RTT measurements greater than 30 seconds in QUIC and limit the
LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078
https://codereview.chromium.org/2185163002/


Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346
https://codereview.chromium.org/2192623002/
==========

[Ryan Hamilton, 2016-07-27 21:33:13]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 21:33:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 21:41:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 21:41:06]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Ryan Hamilton, 2016-07-27 22:16:46]

The CQ bit was checked by rch@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 22:16:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ryan Hamilton, 2016-07-27 22:17:55]

rch@chromium.org changed reviewers:
+ zhongyi@chromium.org

[Zhongyi Shi, 2016-07-27 22:34:29]

Please copy the title "Landing..." to the issue description, thanks!

lgtm!

[Ryan Hamilton, 2016-07-27 22:37:44]

Description was changed from

==========
Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.
 These stats are not yet populated.

Merge internal change: 128466946
https://codereview.chromium.org/2188663003/


Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK
frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519
https://codereview.chromium.org/2192633002/


Add a new flag to require QUIC handshake confirmation, but only for versions
before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128
https://codereview.chromium.org/2187463004/


Ignore RTT measurements greater than 30 seconds in QUIC and limit the
LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078
https://codereview.chromium.org/2185163002/


Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346
https://codereview.chromium.org/2192623002/
==========

to

==========
Landing Recent QUIC changes until 7/26/2016 13:53 UTC

Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.
 These stats are not yet populated.

Merge internal change: 128466946
https://codereview.chromium.org/2188663003/


Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK
frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519
https://codereview.chromium.org/2192633002/


Add a new flag to require QUIC handshake confirmation, but only for versions
before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128
https://codereview.chromium.org/2187463004/


Ignore RTT measurements greater than 30 seconds in QUIC and limit the
LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078
https://codereview.chromium.org/2185163002/


Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346
https://codereview.chromium.org/2192623002/
==========

[Ryan Hamilton, 2016-07-27 22:38:03]

On 2016/07/27 22:34:29, Zhongyi Shi wrote:
> Please copy the title "Landing..." to the issue description, thanks!

Hey, that's my line! :)

Done.

[commit-bot: I haz the power, 2016-07-27 23:26:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:27:00]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2016-07-27 23:29:59]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-07-27 23:30:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-27 23:38:29]

Description was changed from

==========
Landing Recent QUIC changes until 7/26/2016 13:53 UTC

Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.
 These stats are not yet populated.

Merge internal change: 128466946
https://codereview.chromium.org/2188663003/


Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK
frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519
https://codereview.chromium.org/2192633002/


Add a new flag to require QUIC handshake confirmation, but only for versions
before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128
https://codereview.chromium.org/2187463004/


Ignore RTT measurements greater than 30 seconds in QUIC and limit the
LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078
https://codereview.chromium.org/2185163002/


Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346
https://codereview.chromium.org/2192623002/
==========

to

==========
Landing Recent QUIC changes until 7/26/2016 13:53 UTC

Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.
 These stats are not yet populated.

Merge internal change: 128466946
https://codereview.chromium.org/2188663003/


Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK
frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519
https://codereview.chromium.org/2192633002/


Add a new flag to require QUIC handshake confirmation, but only for versions
before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128
https://codereview.chromium.org/2187463004/


Ignore RTT measurements greater than 30 seconds in QUIC and limit the
LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078
https://codereview.chromium.org/2185163002/


Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346
https://codereview.chromium.org/2192623002/
==========

[commit-bot: I haz the power, 2016-07-27 23:38:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-27 23:41:28]

Description was changed from

==========
Landing Recent QUIC changes until 7/26/2016 13:53 UTC

Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.
 These stats are not yet populated.

Merge internal change: 128466946
https://codereview.chromium.org/2188663003/


Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK
frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519
https://codereview.chromium.org/2192633002/


Add a new flag to require QUIC handshake confirmation, but only for versions
before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128
https://codereview.chromium.org/2187463004/


Ignore RTT measurements greater than 30 seconds in QUIC and limit the
LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078
https://codereview.chromium.org/2185163002/


Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346
https://codereview.chromium.org/2192623002/
==========

to

==========
Landing Recent QUIC changes until 7/26/2016 13:53 UTC

Add plumbing for passing stats from calls to ProofSource::GetProof through QUIC.
 These stats are not yet populated.

Merge internal change: 128466946
https://codereview.chromium.org/2188663003/

Switch to PacketNumberQueue interval iteration and avoid allocations in new ACK
frame generation. Guarded by FLAGS_quic_use_packet_number_queue_intervals.

Merge internal change: 128459519
https://codereview.chromium.org/2192633002/

Add a new flag to require QUIC handshake confirmation, but only for versions
before 33 FLAGS_quic_require_handshake_confirmation_pre33.

Merge internal change: 128431128
https://codereview.chromium.org/2187463004/

Ignore RTT measurements greater than 30 seconds in QUIC and limit the
LOG(WARNING) to 10. Protected by existing FLAGS_quic_socket_walltimestamps

Merge internal change: 128425078
https://codereview.chromium.org/2185163002/

Change memmove's back into memcpy's. No functional change. Not flag protected.

memmove is presently ~2.5x faster than memcpy, however isn't inlined with
-minline-all-stringops. It turns out that when these effects combine, the net
result is a no-op for performance.

So let's switch back to memcpy, because memcpy is likely to be improved in the
future, and seeing memmove's where they aren't needed is somewhat surprising.

Merge internal change: 128366346
https://codereview.chromium.org/2192623002/

Committed: https://crrev.com/f90f8dc2cb4c31a11da888eaf267aba1d6e409cd
Cr-Commit-Position: refs/heads/master@{#408274}
==========

[commit-bot: I haz the power, 2016-07-27 23:41:29]

Patchset 3 (id:??) landed as
https://crrev.com/f90f8dc2cb4c31a11da888eaf267aba1d6e409cd
Cr-Commit-Position: refs/heads/master@{#408274}