chrome/browser/resources/chromeos/login/oobe.js - Issue 2189733006: ChromeOS: Implement Language Selection screen of material design OOBE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/login/oobe.js

Issue 2189733006: ChromeOS: Implement Language Selection screen of material design OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use translatable string for OK button text Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/chromeos_strings.grdp ('K') | « chrome/browser/resources/chromeos/login/custom_elements_oobe.js ('k') | chrome/browser/resources/chromeos/login/oobe_buttons.html » ('j') | chrome/browser/resources/chromeos/login/oobe_dialog.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/login/oobe.js

diff --git a/chrome/browser/resources/chromeos/login/oobe.js b/chrome/browser/resources/chromeos/login/oobe.js

index 729a695c31f9ce777e6f29f5290f2413d3636358..7105a8fee2da40e91783eb363acf06276205d57e 100644

--- a/chrome/browser/resources/chromeos/login/oobe.js

+++ b/chrome/browser/resources/chromeos/login/oobe.js

@@ -305,8 +305,11 @@ cr.define('cr.ui.Oobe', function() {

Oobe.setupSelect($('timezone-select'), data.timezoneList);

// ---------- Welcome screen

- $('oobe-welcome-md').currentLanguage =

- Oobe.getSelectedTitle(data.languageList);

+ var welcomeScreen = $('oobe-welcome-md');

+ welcomeScreen.currentLanguage = Oobe.getSelectedTitle(data.languageList);

+ welcomeScreen.oobeLanguages = data.languageList;

+ welcomeScreen.oobeKeyboards = data.inputMethodsList;

stevenjb 2016/07/29 16:11:52 nit: shouldn't we only do this inside the if below

Alexander Alekseev 2016/07/30 00:52:50 Done.

if (data.newOobeUI == 'on') {

$('oobe-connect').hidden = true;