chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html - Issue 2189733006: ChromeOS: Implement Language Selection screen of material design OOBE.

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html

Issue 2189733006: ChromeOS: Implement Language Selection screen of material design OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after review. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/login/custom_elements_oobe.js ('K') | « chrome/browser/resources/chromeos/login/oobe_dialog.js ('k') | chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js » ('j') | chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
	michaelpg 2016/08/02 00:06:38 alphabetize imports alphabetize imports Alexander Alekseev 2016/08/02 04:25:56 Done. Show quoted text On 2016/08/02 00:06:38, michaelpg wrote: > alphabetize imports Done.
	6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-i conset-svg.html">

	7

	8 <iron-iconset-svg name="oobe-i18n-dropdown" size="24">

	9 <svg>

	10 <defs>

	11 <!--

	12 These icons are copied from Polymer's iron-icons and kept in sorted order.

	13 See http://goo.gl/Y1OdAq for instructions on adding additional icons.

	14 -->

	15 <g id="check">

	16 <path d="M9 16.17L4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z">

	17 </path>

	18 </g>

	19 </defs>

	20 </svg>

	21 </iron-iconset-svg>

	22

	23 <dom-module id="oobe-i18n-dropdown">

	24 <template>

	25 <style>

	26 .selected-icon {

	27 color: var(--google-blue-500);
	michaelpg 2016/08/02 00:06:38 import whatever polymer file defines this color import whatever polymer file defines this color Alexander Alekseev 2016/08/02 04:25:56 Done. Show quoted text On 2016/08/02 00:06:38, michaelpg wrote: > import whatever polymer file defines this color Done.
	28 }

	29 </style>

	30 <paper-dropdown-menu no-label-float>

	31 <paper-listbox id="listboxDropdown" class="dropdown-content"

	32 on-iron-select="onSelect_"

	33 on-iron-deselect="onDeselect_">

	34 <template is="dom-repeat" items="[[items]]">

	35 <paper-item item="[[item]]" disabled="[[item.optionGroupName]]">
	michaelpg 2016/08/02 00:06:38 paper-item doesn't have an \|item\| property... paper-item doesn't have an \|item\| property... Alexander Alekseev 2016/08/02 04:25:56 I just need this property in 'iron-select' event d Show quoted text On 2016/08/02 00:06:38, michaelpg wrote: > paper-item doesn't have an \|item\| property... I just need this property in 'iron-select' event detail. Instead of creating another custom element around paper-item, I added property to polymer element. This seems to work. Do you think I should use item$=... ? michaelpg 2016/08/02 20:31:53 use the dom-repeat's modelForElement function: htt Show quoted text On 2016/08/02 04:25:56, Alexander Alekseev wrote: > On 2016/08/02 00:06:38, michaelpg wrote: > > paper-item doesn't have an \|item\| property... > > I just need this property in 'iron-select' event detail. use the dom-repeat's modelForElement function: https://www.polymer-project.org/1.0/docs/api/dom-repeat Show quoted text > Instead of creating another custom element around paper-item, I added property > to polymer element. > > This seems to work. > > Do you think I should use item$=... ?
	36 <div class="flex horizontal layout justified">

	37 <div class="item-name" hidden="[[item.optionGroupName]]">
	michaelpg 2016/08/02 00:06:38 what does this class do? what does this class do? Alexander Alekseev 2016/08/02 04:25:56 Removed. Show quoted text On 2016/08/02 00:06:38, michaelpg wrote: > what does this class do? Removed.
	38 [[item.title]]

	39 </div>

	40 <iron-icon icon="oobe-i18n-dropdown:check" class="selected-icon"

	41 hidden="[[!item.selected]]">

	42 </iron-icon>

	43 </div>

	44 <hr hidden="[[!item.optionGroupName]]">
	michaelpg 2016/08/02 00:06:38 should this be done in CSS or is the <hr> styled p should this be done in CSS or is the <hr> styled properly? Alexander Alekseev 2016/08/02 04:25:56 What do you mean? I need "horizontal line in the Show quoted text On 2016/08/02 00:06:38, michaelpg wrote: > should this be done in CSS or is the <hr> styled properly? What do you mean? I need "horizontal line in the middle of the [empty] entry". This one works. michaelpg 2016/08/02 20:31:53 I mean will this be a default, tall, grey, inset < Show quoted text On 2016/08/02 04:25:56, Alexander Alekseev wrote: > On 2016/08/02 00:06:38, michaelpg wrote: > > should this be done in CSS or is the <hr> styled properly? > > What do you mean? > > I need "horizontal line in the middle of the [empty] entry". This > one works. I mean will this be a default, tall, grey, inset <hr> from the 90's or just a simple black line? We almost never use <hr>.
	45 </paper-item>

	46 </template>

	47 </paper-listbox>

	48 </paper-dropdown-menu>

	49 </template>

	50 </dom-module>

OLD	NEW