chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html - Issue 2189733006: ChromeOS: Implement Language Selection screen of material design OOBE.

Side by Side Diff: chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.html

Issue 2189733006: ChromeOS: Implement Language Selection screen of material design OOBE. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use translatable string for OK button text Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/chromeos/login/oobe_dialog.html ('K') | « chrome/browser/resources/chromeos/login/oobe_dialog.js ('k') | chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js » ('j') | chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/html/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-dropdown-menu/pap er-dropdown-menu.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-listbox/paper-lis tbox.html">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/iron-iconset-svg/iron-i conset-svg.html">

	7

	8 <iron-iconset-svg name="oobe-i18n-dropdown" size="24">

	9 <svg>

	10 <defs>

	11 <g id="check">
	stevenjb 2016/07/29 16:11:52 Attribute where this came from, e.g. see comment i Attribute where this came from, e.g. see comment in cr_elements/icons.html: https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/icons.htm... (It probably also makes sense for login to include a shared icons.html, but that can be cleaned up later) Alexander Alekseev 2016/07/30 00:52:50 Done. Show quoted text On 2016/07/29 16:11:52, stevenjb wrote: > Attribute where this came from, e.g. see comment in cr_elements/icons.html: > https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/icons.htm... > > (It probably also makes sense for login to include a shared icons.html, but that > can be cleaned up later) Done.
	12 <path d="M9 16.17L4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z">

	13 </path>

	14 </g>

	15 </defs>

	16 </svg>

	17 </iron-iconset-svg>

	18

	19 <dom-module id="oobe-i18n-dropdown">

	20 <template>

	21 <style>

	22 .selected-icon {

	23 color: var(--google-blue-500);

	24 }

	25 </style>

	26 <paper-dropdown-menu no-label-float>

	27 <paper-listbox id="listboxDropdown" class="dropdown-content">

	28 <template is="dom-repeat" items$="[[items]]" on-dom-change="onDomChange_ ">
	michaelpg 2016/07/29 06:26:49 items should be property-bound not attribute-bound items should be property-bound not attribute-bound, ie items="[[items]]" michaelpg 2016/07/29 06:26:50 wrap line wrap line Alexander Alekseev 2016/07/30 00:52:50 Done. The problem (was) that it doesn't work when Show quoted text On 2016/07/29 06:26:49, michaelpg wrote: > items should be property-bound not attribute-bound, ie items="[[items]]" Done. The problem (was) that it doesn't work when items are replaced inside onSelect(). this.set() doesn't have this problem, so I removed $. Alexander Alekseev 2016/07/30 00:52:50 Done. Show quoted text On 2016/07/29 06:26:50, michaelpg wrote: > wrap line Done.
	29 <paper-item item="[[item]]" disabled="[[item.optionGroupName]]">

	30 <div class="flex horizontal layout justified">

	31 <div class="item-name" hidden="[[item.optionGroupName]]">

	32 [[item.title]]

	33 </div>

	34 <iron-icon icon="oobe-i18n-dropdown:check" class="selected-icon"

	35 hidden="[[!item.selected]]">

	36 </iron-icon>

	37 </div>

	38 <hr hidden="[[!item.optionGroupName]]">

	39 </paper-item>

	40 </template>

	41 </paper-listbox>

	42 </paper-dropdown-menu>

	43 </template>

	44 </dom-module>

OLD	NEW