Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2189683002: restore code_generator file from b770039, the nSM mock fix (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

restore code_generator file from b770039, the nSM mock fix Committed: https://github.com/dart-lang/dev_compiler/commit/dd55df026bd87bef24b67ae4eef870b78fa91474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -2 lines) Patch
M lib/src/compiler/code_generator.dart View 4 chunks +149 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
TBR. Looks like this file got accidentally reverted in a merge. After restoring it everything ...
4 years, 4 months ago (2016-07-27 16:49:53 UTC) #2
Jennifer Messerly
Committed patchset #1 (id:1) manually as dd55df026bd87bef24b67ae4eef870b78fa91474 (presubmit successful).
4 years, 4 months ago (2016-07-27 16:50:01 UTC) #4
Jacob
4 years, 4 months ago (2016-07-27 16:54:21 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698