StackTrace formatters

tool/input_sdk/private/debugger.dart

Index: tool/input_sdk/private/debugger.dart
diff --git a/tool/input_sdk/private/debugger.dart b/tool/input_sdk/private/debugger.dart
index 0f470d9d1e2905d32b76e9ae5321459f4c9ff229..8e1d912b1b2f0c4e890c61f4f44eb05f9e1959c7 100644
--- a/tool/input_sdk/private/debugger.dart
+++ b/tool/input_sdk/private/debugger.dart
@@ -312,7 +312,7 @@ class JsonMLFormatter {
     // This is stylistically a bit ugly but it eases distinguishing Dart and
     // JS objects.
     var element = new JsonMLElement('span')
-      ..setStyle('background-color: #d9edf7')
+      ..setStyle('background-color: #d9edf7;')
       ..createTextChild(c);
     return element.toJsonML();
   }
@@ -325,7 +325,10 @@ class JsonMLFormatter {
           'padding-left: 0px;'
           'margin-top: 0px;'
           'margin-bottom: 0px;'
-          'margin-left: 12px');
+          'margin-left: 12px;');
+    if (object is StackTrace) {
+      body.addStyle('color: rgb(196, 26, 22);');
+    }
     var children = _simpleFormatter.children(object);
     for (NameValuePair child in children) {
       var li = body.createChild('li');
@@ -374,6 +377,7 @@ class DartFormatter {
       new IterableFormatter(),
       new MapEntryFormatter(),
       new IterableSpanFormatter(),
+      new StackTraceFormatter(),
       new ClassMetadataFormatter(),
       new HeritageClauseFormatter(),
       new LibraryModuleFormatter(),
@@ -835,6 +839,25 @@ class IterableSpanFormatter implements Formatter {
   List<NameValuePair> children(object) => object.children();
 }
 
+class StackTraceFormatter implements Formatter {
+  accept(object) => object is StackTrace;
+
+  String preview(object) => 'StackTrace';
+
+  bool hasChildren(object) => true;
+
+  List<NameValuePair> children(object) {
+    // Using the stack_trace formatting would be ideal, but adding the
+    // dependency or re-writing the code is too messy, so each line of the
+    // StackTrace will be added as its own child.
+    var children = <NameValuePair>[];
+    for (var line in object.toString().replaceAll('at ', '').split('\n')) {

[bmilligan, 2016/07/27 21:39:23]

Is there a better way to do this than iterating through? A method I'm missing? I
was thinking of forEach() but that returns void.

[Jacob, 2016/07/27 21:42:37]

It is safer to first split by \n
then replace
replace('^ + at', '')

what if a file path happened to be?
foo/file name with spaces at .dart

[Alan Knight, 2016/07/27 21:43:36]

I think you're looking for iterable.map

[bmilligan, 2016/07/27 22:08:39]

Done.

[bmilligan, 2016/07/27 22:08:40]

Done.

+      children.add(new NameValuePair(value: line, hideName: true));
+    }
+    return children;
+  }
+}
+
 /// This entry point is automatically invoked by the code generated by
 /// Dart Dev Compiler
 registerDevtoolsFormatter() {