StackTrace formatters

Addition of StackTrace formatters

R=alanknight@google.com, jacobr@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/a3d34798bd2784bb04e24b73c2355df32c807294

[bmilligan, 2016-07-27 21:04:30]

Description was changed from

==========
sdk update


Merge branch 'master' of https://github.com/dart-lang/dev_compiler into children


Generic iteration loop


Library formatter children cleanup


Refactoring library children method


Merge conflict fixes


Library children object fix


Revert test files


Presubmit checks test file updates


Revert pubspec.lock


Revert tests


CL cleanup


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


CL updates


Removal of generic argument parenthesis


delete dart_sdk.js~


Generic type recognition and cleanup


Fix merge conflicts


add pubspec.lock


Library custom formatters


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


return type fix


Nit fixes


Updated IterableSpan


Custom formatter popup booleans


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Private name in loaded LibraryLoader


Debugger library import with name


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


setter for testing


maxspanlength setter


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


comments and 10001 case


naming and logic changes


logic updates and variable renaming


Merge branch 'master' of https://github.com/dart-lang/dev_compiler


Array formatting customized to look like JS

BUG=
==========

to

==========

==========

[bmilligan, 2016-07-27 21:05:23]

bmilligan@google.com changed reviewers:
+ alanknight@google.com, jacobr@google.com

[Alan Knight, 2016-07-27 21:11:56]

lgtm

[Jacob, 2016-07-27 21:12:43]

lgtm

[bmilligan, 2016-07-27 21:39:23]

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:854: for (var line in
object.toString().replaceAll('at ', '').split('\n')) {
Is there a better way to do this than iterating through? A method I'm missing? I
was thinking of forEach() but that returns void.

[Jacob, 2016-07-27 21:42:37]

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:854: for (var line in
object.toString().replaceAll('at ', '').split('\n')) {
On 2016/07/27 21:39:23, bmilligan wrote:
> Is there a better way to do this than iterating through? A method I'm missing?
I
> was thinking of forEach() but that returns void.

It is safer to first split by \n
then replace
replace('^ + at', '')

what if a file path happened to be?
foo/file name with spaces at .dart

[Alan Knight, 2016-07-27 21:43:36]

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:854: for (var line in
object.toString().replaceAll('at ', '').split('\n')) {
On 2016/07/27 21:39:23, bmilligan wrote:
> Is there a better way to do this than iterating through? A method I'm missing?
I
> was thinking of forEach() but that returns void.

I think you're looking for iterable.map

[bmilligan, 2016-07-27 22:08:40]

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
File tool/input_sdk/private/debugger.dart (right):

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:854: for (var line in
object.toString().replaceAll('at ', '').split('\n')) {
On 2016/07/27 21:42:37, Jacob wrote:
> On 2016/07/27 21:39:23, bmilligan wrote:
> > Is there a better way to do this than iterating through? A method I'm
missing?
> I
> > was thinking of forEach() but that returns void.
> 
> It is safer to first split by \n
> then replace
> replace('^ + at', '')
> 
> what if a file path happened to be?
> foo/file name with spaces at .dart

Done.

https://codereview.chromium.org/2189673002/diff/40001/tool/input_sdk/private/...
tool/input_sdk/private/debugger.dart:854: for (var line in
object.toString().replaceAll('at ', '').split('\n')) {
On 2016/07/27 21:43:36, Alan Knight wrote:
> On 2016/07/27 21:39:23, bmilligan wrote:
> > Is there a better way to do this than iterating through? A method I'm
missing?
> I
> > was thinking of forEach() but that returns void.
> 
> I think you're looking for iterable.map

Done.

[bmilligan, 2016-07-27 22:14:04]

Description was changed from

==========

==========

to

==========
Addition of StackTrace formatters
==========

[bmilligan, 2016-07-27 22:15:08]

Description was changed from

==========
Addition of StackTrace formatters
==========

to

==========
Addition of StackTrace formatters

R=alanknight@google.com, jacobr@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/a3d34798bd2784bb04e24b73c235...
==========

[bmilligan, 2016-07-27 22:15:10]

Committed patchset #5 (id:80001) manually as
a3d34798bd2784bb04e24b73c2355df32c807294 (presubmit successful).

[Jacob, 2016-07-27 22:15:59]

lgtm