Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2189663002: Add a flag to help platform ports bootstrap V8 (Closed)

Created:
4 years, 4 months ago by danno
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a flag to help platform ports bootstrap V8 A "--minimal" flag turns off all optimizing compilers and activates the interpreter. The idea is that with this flag activated, only the platform-specific stubs and a Turbofan implementation must be complete to start d8 and run the bulk of the tests. Note that although this flag is constructed as a runtime flag, it must be set to true when building the snapshot and therefore creates a compile-time dependency. BUG=chromium:608675 Committed: https://crrev.com/c07c675e9a30adc57be25eaa7b87d69d31fc2090 Cr-Commit-Position: refs/heads/master@{#38150}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : d8 starts #

Patch Set 4 : Untoggle flag #

Patch Set 5 : Rename flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -25 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 1 chunk +12 lines, -7 lines 0 comments Download
M src/code-stubs.h View 1 2 7 chunks +13 lines, -3 lines 0 comments Download
M src/code-stubs.cc View 1 2 3 4 11 chunks +18 lines, -10 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 4 1 chunk +44 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-array.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
danno
PTAL
4 years, 4 months ago (2016-07-28 13:01:22 UTC) #1
danno
PTAL
4 years, 4 months ago (2016-07-28 13:01:53 UTC) #3
Benedikt Meurer
Awesome. I'd pick a different name, i.e. --bootstrap or --minimal. LGTM.
4 years, 4 months ago (2016-07-28 16:38:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189663002/80001
4 years, 4 months ago (2016-07-28 21:36:46 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 4 months ago (2016-07-28 22:15:09 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 22:16:06 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c07c675e9a30adc57be25eaa7b87d69d31fc2090
Cr-Commit-Position: refs/heads/master@{#38150}

Powered by Google App Engine
This is Rietveld 408576698