Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2189633003: Force v8::internal::HeapObjectsSet::SetTag to be out-of-lined. (Closed)

Created:
4 years, 4 months ago by dcheng
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Force v8::internal::HeapObjectsSet::SetTag to be out-of-lined. This reduces the size of GetStrongGcSubrootName() from 77 KB to 10KB. BUG=5240 Committed: https://crrev.com/606e1ada1703c4f62cf185da9a9eaeb58c95c168 Cr-Commit-Position: refs/heads/master@{#38123}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/profiler/heap-snapshot-generator.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
4 years, 4 months ago (2016-07-28 08:33:43 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-07-28 08:46:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189633003/1
4 years, 4 months ago (2016-07-28 08:58:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 09:19:05 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 09:21:24 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/606e1ada1703c4f62cf185da9a9eaeb58c95c168
Cr-Commit-Position: refs/heads/master@{#38123}

Powered by Google App Engine
This is Rietveld 408576698