Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2189603002:
[tools/perf] Add integration test for about://tracing UI (Closed)
Description[tools/perf] Add integration test for about://tracing UI
BUG=631812, 631535, 630030
Committed: https://crrev.com/a6c428bad618519ab8c696f697a4208022c6d9b3
Cr-Commit-Position: refs/heads/master@{#408143}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Address Annie's comment #Patch Set 3 : Disable test on windows #Messages
Total messages: 21 (10 generated)
nednguyen@google.com changed reviewers: + sullivan@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2189603002/diff/1/tools/perf/core/about_traci... File tools/perf/core/about_tracing_integration_test.py (right): https://codereview.chromium.org/2189603002/diff/1/tools/perf/core/about_traci... tools/perf/core/about_tracing_integration_test.py:9: }''' What's this for? https://codereview.chromium.org/2189603002/diff/1/tools/perf/core/about_traci... tools/perf/core/about_tracing_integration_test.py:21: return document.querySelector('tr-ui-timeline-view').shadowRoot. I wanted to check that you tested this at ToT? The migration guide warns against using shadowRoot in 1.0 (buried here: https://www.polymer-project.org/1.0/docs/migration#dom-apis) but I don't see clear guidance on how well it is supported. +Kari I've seen you make changes from shadowRoot -> root did you find clear docs on this anywhere? (If the tests pass we can discuss this for a follow up) https://codereview.chromium.org/2189603002/diff/1/tools/perf/core/about_traci... tools/perf/core/about_tracing_integration_test.py:25: getElementById('record-button').click();''') Why not use the ClickElement method in action_runner here and below?
Oops, actually +Kari to see if she knows about using shadowRoot like this in polymer 1.0
Verified that this test passed on TOT. https://codereview.chromium.org/2189603002/diff/1/tools/perf/core/about_traci... File tools/perf/core/about_tracing_integration_test.py (right): https://codereview.chromium.org/2189603002/diff/1/tools/perf/core/about_traci... tools/perf/core/about_tracing_integration_test.py:9: }''' On 2016/07/27 12:40:39, sullivan wrote: > What's this for? Removed. https://codereview.chromium.org/2189603002/diff/1/tools/perf/core/about_traci... tools/perf/core/about_tracing_integration_test.py:21: return document.querySelector('tr-ui-timeline-view').shadowRoot. On 2016/07/27 12:40:39, sullivan wrote: > I wanted to check that you tested this at ToT? The migration guide warns against > using shadowRoot in 1.0 (buried here: > https://www.polymer-project.org/1.0/docs/migration#dom-apis) but I don't see > clear guidance on how well it is supported. > > +Kari I've seen you make changes from shadowRoot -> root did you find clear docs > on this anywhere? > > (If the tests pass we can discuss this for a follow up) Done. https://codereview.chromium.org/2189603002/diff/1/tools/perf/core/about_traci... tools/perf/core/about_tracing_integration_test.py:25: getElementById('record-button').click();''') On 2016/07/27 12:40:39, sullivan wrote: > Why not use the ClickElement method in action_runner here and below? Done.
lgtm
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [tools/perf] Add integration test for about://tracing UI BUG=631812,631535 ========== to ========== [tools/perf] Add integration test for about://tracing UI BUG=631812,631535,630030 ==========
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from sullivan@chromium.org Link to the patchset: https://codereview.chromium.org/2189603002/#ps40001 (title: "Disable test on windows")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
nduca@chromium.org changed reviewers: + nduca@chromium.org
this lgtm from a driveby, but we should probably figure out how to have the implicit api between telemetry <->catapult a bit more defined.
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Add integration test for about://tracing UI BUG=631812,631535,630030 ========== to ========== [tools/perf] Add integration test for about://tracing UI BUG=631812,631535,630030 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Add integration test for about://tracing UI BUG=631812,631535,630030 ========== to ========== [tools/perf] Add integration test for about://tracing UI BUG=631812,631535,630030 Committed: https://crrev.com/a6c428bad618519ab8c696f697a4208022c6d9b3 Cr-Commit-Position: refs/heads/master@{#408143} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/a6c428bad618519ab8c696f697a4208022c6d9b3 Cr-Commit-Position: refs/heads/master@{#408143}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2206563002/ by gab@chromium.org. The reason for reverting is: core.about_tracing_integration_test.AboutTracingIntegrationTest.testBasicTraceRecording has been very flaky on https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests Not sure what the proper logs for these are but maybe something like : [1/2] core.about_tracing_integration_test.AboutTracingIntegrationTest.testBasicTraceRecording failed unexpectedly 76.0656s: Chrome build location for mac_x86_64 not found. Browser will be run without Flash. Requested remote debugging port: 0 Starting Chrome ['/b/c/b/Mac10_10_Tests/isolated_run50QHcQ/out/Release/Chromium.app/Contents/MacOS/Chromium', '--enable-net-benchmarking', '--metrics-recording-only', '--no-default-browser-check', '--no-first-run', '--enable-gpu-benchmarking', '--disable-background-networking', '--no-proxy-server', '--disable-component-extensions-with-background-pages', '--disable-default-apps', '--remote-debugging-port=0', '--enable-crash-reporter-for-testing', '--window-size=1280,1024', '--user-data-dir=/b/c/b/Mac10_10_Tests/isolated_tmpcbChpb/tmpr_Xm7S', 'about:blank'] Discovered ephemeral port 54325 OS: mac yosemite Model: Macmini GPU device 0: VENDOR = 0x8086 (Intel), DEVICE = 0xa2e GPU Attributes: adapter_luid : 0.0 amd_switchable : False basic_info_state : 1 can_lose_context : False context_info_state : 1 direct_rendering : True driver_date : driver_vendor : driver_version : 10.6.33 encrypted_only : False gl_extensions : GL_ARB_color_buffer_float GL_ARB_depth_buffer_float GL_ARB_depth_clamp GL_ARB_depth_texture GL_ARB_draw_buffers GL_ARB_draw_elements_base_vertex GL_ARB_draw_instanced GL_ARB_fragment_program GL_ARB_fragment_program_shadow GL_ARB_fragment_shader GL_ARB_framebuffer_object GL_ARB_framebuffer_sRGB GL_ARB_half_float_pixel GL_ARB_half_float_vertex GL_ARB_instanced_arrays GL_ARB_multisample GL_ARB_multitexture GL_ARB_occlusion_query GL_ARB_pixel_buffer_object GL_ARB_point_parameters GL_ARB_point_sprite GL_ARB_provoking_vertex GL_ARB_seamless_cube_map GL_ARB_shader_objects GL_ARB_shader_texture_lod GL_ARB_shading_language_100 GL_ARB_shadow GL_ARB_sync GL_ARB_texture_border_clamp GL_ARB_texture_compression GL_ARB_texture_compression_rgtc GL_ARB_texture_cube_map GL_ARB_texture_env_add GL_ARB_texture_env_combine GL_ARB_texture_env_crossbar GL_ARB_texture_env_dot3 GL_ARB_texture_float GL_ARB_texture_mirrored_repeat GL_ARB_texture_non_power_of_two GL_ARB_texture_rectangle GL_ARB_texture_rg GL_ARB_transpose_matrix GL_ARB_vertex_array_bgra GL_ARB_vertex_blend GL_ARB_vertex_buffer_object GL_ARB_vertex_program GL_ARB_vertex_shader GL_ARB_window_pos GL_EXT_abgr GL_EXT_bgra GL_EXT_blend_color GL_EXT_blend_equation_separate GL_EXT_blend_func_separate GL_EXT_blend_minmax GL_EXT_blend_subtract GL_EXT_clip_volume_hint GL_EXT_debug_label GL_EXT_debug_marker GL_EXT_draw_buffers2 GL_EXT_draw_range_elements GL_EXT_fog_coord GL_EXT_framebuffer_blit GL_EXT_framebuffer_multisample GL_EXT_framebuffer_multisample_blit_scaled GL_EXT_framebuffer_object GL_EXT_framebuffer_sRGB GL_EXT_geometry_shader4 GL_EXT_gpu_program_parameters GL_EXT_gpu_shader4 GL_EXT_multi_draw_arrays GL_EXT_packed_depth_stencil GL_EXT_packed_float GL_EXT_provoking_vertex GL_EXT_rescale_normal GL_EXT_secondary_color GL_EXT_separate_specular_color GL_EXT_shadow_funcs GL_EXT_stencil_two_side GL_EXT_stencil_wrap GL_EXT_texture_array GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc GL_EXT_texture_env_add GL_EXT_texture_filter_anisotropic GL_EXT_texture_integer GL_EXT_texture_lod_bias GL_EXT_texture_rectangle GL_EXT_texture_shared_exponent GL_EXT_texture_sRGB GL_EXT_texture_sRGB_decode GL_EXT_timer_query GL_EXT_transform_feedback GL_EXT_vertex_array_bgra GL_APPLE_aux_depth_stencil GL_APPLE_client_storage GL_APPLE_element_array GL_APPLE_fence GL_APPLE_float_pixels GL_APPLE_flush_buffer_range GL_APPLE_flush_render GL_APPLE_object_purgeable GL_APPLE_packed_pixels GL_APPLE_pixel_buffer GL_APPLE_rgb_422 GL_APPLE_row_bytes GL_APPLE_specular_vector GL_APPLE_texture_range GL_APPLE_transform_hint GL_APPLE_vertex_array_object GL_APPLE_vertex_array_range GL_APPLE_vertex_point_size GL_APPLE_vertex_program_evaluators GL_APPLE_ycbcr_422 GL_ATI_separate_stencil GL_ATI_texture_env_combine3 GL_ATI_texture_float GL_ATI_texture_mirror_once GL_IBM_rasterpos_clip GL_NV_blend_square GL_NV_conditional_render GL_NV_depth_clamp GL_NV_fog_distance GL_NV_light_max_exponent GL_NV_texgen_reflection GL_NV_texture_barrier GL_SGIS_generate_mipmap GL_SGIS_texture_edge_clamp GL_SGIS_texture_lod gl_renderer : Intel Iris OpenGL Engine gl_reset_notification_strategy: 0 gl_vendor : Intel Inc. gl_version : 2.1 INTEL-10.6.33 gl_ws_extensions : gl_ws_vendor : gl_ws_version : in_process_gpu : False initialization_time : 0.035222 jpeg_decode_accelerator_supported: False lenovo_dcute : False max_framerate_denominator: 1 max_framerate_numerator: 30 max_msaa_samples : 8 max_resolution_height: 2160 max_resolution_width: 4096 min_resolution_height: 16 min_resolution_width: 16 optimus : False pixel_shader_version: 1.20 process_crash_count : 0 profile : 0 sandboxed : True software_rendering : False vertex_shader_version: 1.20 video_decode_accelerator_flags: 0 Feature Status: 2d_canvas : enabled flash_3d : enabled flash_stage3d : enabled flash_stage3d_baseline: enabled gpu_compositing : enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization : enabled video_decode : enabled video_encode : enabled vpx_decode : enabled webgl : enabled Driver Bug Workarounds: disable_framebuffer_cmaa disable_multimonitor_multisampling disable_overlay_ca_layers disable_webgl_rgb_multisampling_usage msaa_is_slow pack_parameters_workaround_with_pack_buffer regenerate_struct_names scalarize_vec_and_mat_constructor_args set_zero_level_before_generating_mipmap unfold_short_circuit_as_ternary_operation unpack_alignment_workaround_with_unpack_buffer use_intermediary_for_copy_texture_image use_shadowed_tex_level_params validate_multisample_buffer_allocation *************** BROWSER STANDARD OUTPUT *************** 2016-07-27 11:14:04.608 Chromium[6176:41586] NSWindow warning: adding an unknown subview: <FullSizeContentView: 0x7f9165047eb0> 2016-07-27 11:14:04.608 Chromium[6176:41586] Call stack: ( "+callStackSymbols disabled for performance reasons" ) [6176:1299:0727/111407:ERROR:CONSOLE(2054)] "Error: Could not find an importer for the provided eventData. at Import.createImports (chrome://tracing/tracing.js:1457:64) at Task.run (chrome://tracing/tracing.js:2042:13) at runAnother (chrome://tracing/tracing.js:2054:136) at runTask (chrome://tracing/tracing.js:2017:57) at processIdleWork (chrome://tracing/tracing.js:2023:116) at window.requestIdleCallback.timeout (chrome://tracing/tracing.js:2011:81)", source: chrome://tracing/tracing.js (2054). |
