Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2189583003:
align cap hairline first point
Descriptionalign cap hairline first point
Hairlines with square caps move the endpoints out by 1/2 pixel.
The last point needs to be the first adjusted point, instead
of the point supplied to move to.
R=fmalita@chromium.org
TBR=reed@google.com
BUG=617658
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003
Committed: https://skia.googlesource.com/skia/+/52f85d4d09b815fce6bfe296a1dd2cbf8d792f05
Patch Set 1 #Patch Set 2 : fix move / close #Patch Set 3 : align start and last separately #Patch Set 4 : try a less intrusive change #Messages
Total messages: 26 (17 generated)
Description was changed from ========== align cap hairline first point Hairlines with square caps move the endpoints out by 1/2 pixel. The last point needs to be the first adjusted point, instead of the point supplied to move to. R=fmalita@chromium.org TBR=reed@google.com BUG=617658 ========== to ========== align cap hairline first point Hairlines with square caps move the endpoints out by 1/2 pixel. The last point needs to be the first adjusted point, instead of the point supplied to move to. R=fmalita@chromium.org TBR=reed@google.com BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003 ==========
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. I assume the GM diffs are correct/expected.
On 2016/07/27 19:08:20, f(malita) wrote: > LGTM. I assume the GM diffs are correct/expected. There are GM differences -- I'm examining them now to make sure they're an improvement
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by caryclark@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== align cap hairline first point Hairlines with square caps move the endpoints out by 1/2 pixel. The last point needs to be the first adjusted point, instead of the point supplied to move to. R=fmalita@chromium.org TBR=reed@google.com BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003 ========== to ========== align cap hairline first point Hairlines with square caps move the endpoints out by 1/2 pixel. The last point needs to be the first adjusted point, instead of the point supplied to move to. R=fmalita@chromium.org TBR=reed@google.com BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003 Committed: https://skia.googlesource.com/skia/+/52f85d4d09b815fce6bfe296a1dd2cbf8d792f05 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/52f85d4d09b815fce6bfe296a1dd2cbf8d792f05
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2188483007/ by tomhudson@google.com. The reason for reverting is: Speculative revert in case this is blocking our roll..
Message was sent while issue was closed.
On 2016/07/28 14:36:17, tomhudson wrote: > A revert of this CL (patchset #2 id:20001) has been created in > https://codereview.chromium.org/2188483007/ by mailto:tomhudson@google.com. > > The reason for reverting is: Speculative revert in case this is blocking our > roll.. This one diff looks suspicious: https://storage.googleapis.com/chromium-layout-test-archives/linux_precise_bl... Only repros if the browser window is resized very small to scale everything down.
Message was sent while issue was closed.
Good to know how to repro. I'll investigate once I get back from vacation
Message was sent while issue was closed.
Description was changed from ========== align cap hairline first point Hairlines with square caps move the endpoints out by 1/2 pixel. The last point needs to be the first adjusted point, instead of the point supplied to move to. R=fmalita@chromium.org TBR=reed@google.com BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003 Committed: https://skia.googlesource.com/skia/+/52f85d4d09b815fce6bfe296a1dd2cbf8d792f05 ========== to ========== align cap hairline first point Hairlines with square caps move the endpoints out by 1/2 pixel. The last point needs to be the first adjusted point, instead of the point supplied to move to. R=fmalita@chromium.org TBR=reed@google.com BUG=617658 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2189583003 Committed: https://skia.googlesource.com/skia/+/52f85d4d09b815fce6bfe296a1dd2cbf8d792f05 ==========
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Patchset #3 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by caryclark@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... |
