Use server ID to identify server cards.

Use server ID to identify server cards.

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482
Committed: https://crrev.com/9294d05d3425a1881b15af8043e72e47339f214b
Cr-Commit-Position: refs/heads/master@{#408827}

[please use gerrit instead, 2016-07-27 03:42:01]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-27 03:42:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-27 03:44:59]

Description was changed from

==========
Don't change server card GUIDs after updating their billing address.

PaymentRequest UI relies on Autofill credit cards to not change their
GUID while the UI is displayed. The Autofill server cards change their
GUID on every re-read from the database. PaymentRequest UI enables users
to change the billing address ID of server cards. This operation should
not re-read the database, as that will change the server card's GUID,
thus violating PaymentRequest's assumption about unchanging GUIDs.

BUG=631013
==========

to

==========
Don't change server card GUIDs after updating their billing address.

PaymentRequest UI relies on Autofill credit cards to not change their
GUID while the UI is displayed. The Autofill server cards change their
GUID on every re-read from the database. PaymentRequest UI enables users
to change the billing address ID of server cards. This operation should
not re-read the database, as that will change the server card's GUID,
thus violating PaymentRequest's assumption about unchanging GUIDs.

BUG=631878
==========

[commit-bot: I haz the power, 2016-07-27 04:42:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-27 04:42:15]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-07-27 04:59:23]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mathp@chromium.org

[please use gerrit instead, 2016-07-27 04:59:24]

dfalcantara, ptal the integration tests.

mathp, ptal autofill.

[please use gerrit instead, 2016-07-27 08:05:59]

On 2016/07/27 04:59:24, rouslan wrote:
> dfalcantara, ptal the integration tests.
> 
> mathp, ptal autofill.

Actually, this patch is using the wrong approach. It's merely a bandage, because
any call to Refresh() will ruin PaymentRequest's assumptions. So the correct
approach is to remove the assumption that server cards will not change GUIDs.
Instead, PaymentRequeest should (1) use the unchanging server_id to identify
server cards to update on disk and (2) do not re-read data from disk when user
taps [pay]. I will upload a new patch for this in a couple of days.

[please use gerrit instead, 2016-07-27 08:06:17]

rouslan@chromium.org changed reviewers:
- dfalcantara@chromium.org, mathp@chromium.org

[please use gerrit instead, 2016-07-28 21:31:32]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-28 21:32:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-28 21:49:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-28 21:49:31]

Dry run: Try jobs failed on following builders:
  win8_chromium_gyp_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp...)

[please use gerrit instead, 2016-07-29 20:39:50]

Description was changed from

==========
Don't change server card GUIDs after updating their billing address.

PaymentRequest UI relies on Autofill credit cards to not change their
GUID while the UI is displayed. The Autofill server cards change their
GUID on every re-read from the database. PaymentRequest UI enables users
to change the billing address ID of server cards. This operation should
not re-read the database, as that will change the server card's GUID,
thus violating PaymentRequest's assumption about unchanging GUIDs.

BUG=631878
==========

to

==========
Don't change server card GUIDs after updating their billing address.

PaymentRequest UI relies on Autofill credit cards to not change their
GUID while the UI is displayed. The Autofill server cards change their
GUID on every re-read from the database. PaymentRequest UI enables users
to change the billing address ID of server cards. This operation should
not re-read the database, as that will change the server card's GUID,
thus violating PaymentRequest's assumption about unchanging GUIDs.

BUG=632482
==========

[please use gerrit instead, 2016-07-29 21:26:44]

Patchset #2 (id:20001) has been deleted

[please use gerrit instead, 2016-07-29 22:38:11]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 22:38:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-29 22:42:50]

Description was changed from

==========
Don't change server card GUIDs after updating their billing address.

PaymentRequest UI relies on Autofill credit cards to not change their
GUID while the UI is displayed. The Autofill server cards change their
GUID on every re-read from the database. PaymentRequest UI enables users
to change the billing address ID of server cards. This operation should
not re-read the database, as that will change the server card's GUID,
thus violating PaymentRequest's assumption about unchanging GUIDs.

BUG=632482
==========

to

==========
Use server ID to identify server cards.

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482
==========

[please use gerrit instead, 2016-07-29 22:46:38]

Patchset #1 (id:1) has been deleted

[please use gerrit instead, 2016-07-29 22:46:45]

Patchset #1 (id:40001) has been deleted

[please use gerrit instead, 2016-07-29 22:53:39]

The CQ bit was checked by rouslan@chromium.org to run a CQ dry run

[please use gerrit instead, 2016-07-29 22:53:57]

Patchset #1 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-07-29 22:54:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[please use gerrit instead, 2016-07-29 22:55:05]

rouslan@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[please use gerrit instead, 2016-07-29 22:55:06]

dfalcantara, ptal.

Sorry for the large patch size. It's mostly due to adding "serverId" as a
parameter to CreditCard constructor.

[please use gerrit instead, 2016-07-29 22:58:14]

rouslan@chromium.org changed reviewers:
+ mathp@chromium.org

[please use gerrit instead, 2016-07-29 22:58:14]

Mathieu, owners ptal:

chrome/browser/autofill/android/personal_data_manager_android.h
chrome/browser/autofill/android/personal_data_manager_android.cc
components/autofill/core/browser/credit_card.h
components/autofill/core/browser/personal_data_manager.cc

[commit-bot: I haz the power, 2016-07-29 23:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 23:42:15]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[gone, 2016-07-30 00:00:15]

Java bits lgtm.

[Mathieu, 2016-07-30 00:43:16]

lgtm

[please use gerrit instead, 2016-07-30 00:44:47]

Description was changed from

==========
Use server ID to identify server cards.

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482
==========

to

==========
Use server ID to identify server cards.

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482
==========

[please use gerrit instead, 2016-07-30 00:45:04]

The CQ bit was checked by rouslan@chromium.org

[commit-bot: I haz the power, 2016-07-30 00:45:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 01:08:09]

Description was changed from

==========
Use server ID to identify server cards.

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482
==========

to

==========
Use server ID to identify server cards.

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482
==========

[commit-bot: I haz the power, 2016-07-30 01:08:11]

Committed patchset #1 (id:80001)

[commit-bot: I haz the power, 2016-07-30 01:10:29]

Description was changed from

==========
Use server ID to identify server cards.

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482
==========

to

==========
Use server ID to identify server cards.

Server cards can change their GUIDs when the in-memory cache is re-read
from disk. This refresh happens whenever any autofill data is written to
disk, e.g., when updating the billing address of a server card.
Therefore, the stable server ID should be used to identify server cards.

BUG=632482

Committed: https://crrev.com/9294d05d3425a1881b15af8043e72e47339f214b
Cr-Commit-Position: refs/heads/master@{#408827}
==========

[commit-bot: I haz the power, 2016-07-30 01:10:30]

Patchset 1 (id:??) landed as
https://crrev.com/9294d05d3425a1881b15af8043e72e47339f214b
Cr-Commit-Position: refs/heads/master@{#408827}

[martin.gonzalez110565, 2016-09-16 02:58:18]

martin.gonzalez110565@gmail.com changed reviewers:
+ martin.gonzalez110565@gmail.com

[martin.gonzalez110565, 2016-09-16 03:01:51]

lgtm

[martin.gonzalez110565, 2016-09-16 03:01:54]

lgtm