Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2189553003: [ios] improved retry logic for windowID injection. (Closed)

Created:
4 years, 4 months ago by Eugene But (OOO till 7-30)
Modified:
4 years, 4 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] improved retry logic for windowID injection. Make windowID script return boolean result to indicate if retry is necessary instead of retrying on exception. BUG=628832 Committed: https://crrev.com/9108e9a2775ec67ce108a0f34047a74869672bdb Cr-Commit-Position: refs/heads/master@{#408232}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M ios/web/web_state/js/crw_js_window_id_manager.mm View 1 chunk +17 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eugene But (OOO till 7-30)
4 years, 4 months ago (2016-07-27 20:37:55 UTC) #6
kkhorimoto
lgtm
4 years, 4 months ago (2016-07-27 20:41:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189553003/1
4 years, 4 months ago (2016-07-27 20:44:47 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 20:49:29 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 20:50:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9108e9a2775ec67ce108a0f34047a74869672bdb
Cr-Commit-Position: refs/heads/master@{#408232}

Powered by Google App Engine
This is Rietveld 408576698