Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2189543004: [Password Generation] Add FormFieldData.properties_mask to mojo (Closed)

Created:
4 years, 4 months ago by kolos1
Modified:
4 years, 4 months ago
Reviewers:
dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, rouslan+autofill_chromium.org, jam, browser-components-watch_chromium.org, yzshen+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, Aaron Boodman, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, darin (slow to review), abarth-chromium, ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pg_count_modified_fields
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password Generation] Add FormFieldData.properties_mask to mojo The similar CL for IPC https://codereview.chromium.org/2148303005/ BUG=582434 Committed: https://crrev.com/2d7256e0b39ae12ec3e2ec38da36857f8a0854e1 Cr-Commit-Position: refs/heads/master@{#408735}

Patch Set 1 #

Patch Set 2 : o #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M components/autofill/content/public/cpp/autofill_types_struct_traits.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/content/public/cpp/autofill_types_struct_traits.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/autofill/content/public/cpp/autofill_types_struct_traits_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/public/interfaces/autofill_types.mojom View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 2148303005 Patch 510001

Messages

Total messages: 10 (5 generated)
kolos1
dcheng@: Please review this CL. Thanks. Best regards, Maxim
4 years, 4 months ago (2016-07-28 16:33:40 UTC) #3
dcheng
lgtm
4 years, 4 months ago (2016-07-29 04:07:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189543004/20001
4 years, 4 months ago (2016-07-29 19:27:49 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 20:59:11 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:02:30 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/2d7256e0b39ae12ec3e2ec38da36857f8a0854e1
Cr-Commit-Position: refs/heads/master@{#408735}

Powered by Google App Engine
This is Rietveld 408576698