Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2189533005: Settings Router Refactor: Fix Closure compile issue from merge conflict. (Closed)

Created:
4 years, 4 months ago by tommycli
Modified:
4 years, 4 months ago
Reviewers:
jdufault, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings Router Refactor: Fix Closure compile issue from merge conflict. Device page added a new navigation at the same time as the mega router navigateTo patch. This fixes the Closure compile issue that resulted from that collision. BUG=608115 TBR=jdufault@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation NOTRY=true Committed: https://crrev.com/97e96fefb27bce1fc57e0afc563a6a48ab6f8338 Cr-Commit-Position: refs/heads/master@{#408482}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/device_page/device_page.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
tommycli
jdufault: PTAL merge conflict closure compile redness fix
4 years, 4 months ago (2016-07-28 21:10:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189533005/1
4 years, 4 months ago (2016-07-28 21:10:55 UTC) #4
dpapad
lgtm
4 years, 4 months ago (2016-07-28 21:13:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189533005/1
4 years, 4 months ago (2016-07-28 21:20:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-28 21:29:32 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-28 21:30:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97e96fefb27bce1fc57e0afc563a6a48ab6f8338
Cr-Commit-Position: refs/heads/master@{#408482}

Powered by Google App Engine
This is Rietveld 408576698