Oilpan: IDBCursor should be detached from IDBRequest when the IDBRequest stops

Source/core/workers/WorkerGlobalScope.cpp

Index: Source/core/workers/WorkerGlobalScope.cpp
diff --git a/Source/core/workers/WorkerGlobalScope.cpp b/Source/core/workers/WorkerGlobalScope.cpp
index 70781285349df847ad0924c5a3d0752db896cc63..3f5da1213d26a4021f958e5c87d5a075b89f3867 100644
--- a/Source/core/workers/WorkerGlobalScope.cpp
+++ b/Source/core/workers/WorkerGlobalScope.cpp
@@ -196,6 +196,10 @@ void WorkerGlobalScope::dispose()
 {
     ASSERT(thread()->isCurrentThread());
 
+    if (m_script)
+        m_script->dispose();
+    lifecycleNotifier().notifyContextWillBeDestroyed();
+
     clearScript();

[haraken, 2014/04/01 05:56:14]

I'm afraid this is very hacky. This code is the way it is to make sure that
things happen in the following order:

(1) DOMWrapperWorld is disposed.
(2) contextWillBeDestroyed() is called on IDBRequest objects, and they die.
(3) didStopWorkerRunLoop() notification is sent to the Chromium side.
(4) ThreadState::detach() is called.
(5) Isolate is disposed.

[Mads Ager (chromium), 2014/04/01 11:38:38]

This code is one big hair ball already where things have to happen in exactly
the right order for things to die properly. I'm not sure this is much worse than
it was before? Maybe some comments on the shutdown order would be in order.

     clearInspector();
     setClient(0);