Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 2189523004: power_save_blocker_x11.cc depends on dbus (Closed)

Created:
4 years, 4 months ago by Mostyn Bramley-Moore
Modified:
4 years, 4 months ago
Reviewers:
boliu
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

power_save_blocker_x11.cc depends on dbus Committed: https://crrev.com/3f20c13e3c4923917ae91fcb84de2b0935d64e66 Cr-Commit-Position: refs/heads/master@{#408275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/power_save_blocker/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Mostyn Bramley-Moore
@boliu: please take a look at this GN fixup.
4 years, 4 months ago (2016-07-27 22:35:42 UTC) #4
boliu
lgtm
4 years, 4 months ago (2016-07-27 22:36:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189523004/1
4 years, 4 months ago (2016-07-27 22:40:54 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 23:39:34 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 23:41:31 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f20c13e3c4923917ae91fcb84de2b0935d64e66
Cr-Commit-Position: refs/heads/master@{#408275}

Powered by Google App Engine
This is Rietveld 408576698