chrome/test/base/chrome_render_view_test.cc - Issue 2189513004: Blink: prevent didAssociateFormControls notification while parsing the document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/chrome_render_view_test.cc

Issue 2189513004: Blink: prevent didAssociateFormControls notification while parsing the document. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | components/autofill/content/renderer/autofill_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/base/chrome_render_view_test.cc

diff --git a/chrome/test/base/chrome_render_view_test.cc b/chrome/test/base/chrome_render_view_test.cc

index acd14925db7b0ca5d8f042363f605f40ac8dc98b..27bbff796fdfdcd18bcd1124f156c403bbdb41fe 100644

--- a/chrome/test/base/chrome_render_view_test.cc

+++ b/chrome/test/base/chrome_render_view_test.cc

@@ -79,9 +79,8 @@ class MockAutofillAgent : public AutofillAgent {

MOCK_CONST_METHOD0(IsUserGesture, bool());

private:

- void didAssociateFormControls(

- const blink::WebVector<blink::WebNode>& nodes) override {

- AutofillAgent::didAssociateFormControls(nodes);

+ void didAssociateFormControlsDynamically() override {

+ AutofillAgent::didAssociateFormControlsDynamically();

if (run_loop_)

run_loop_->Quit();

}