third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2189513004: Blink: prevent didAssociateFormControls notification while parsing the document.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2189513004: Blink: prevent didAssociateFormControls notification while parsing the document. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/autofill_agent.cc ('K') | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/public/web/WebAutofillClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index da897ce2e41e776c0843f46d6083df3d2d0316f8..526eab096e521a201d4329f9f64a03de0d5f29e0 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -939,11 +939,11 @@ void ChromeClientImpl::annotatedRegionsChanged()

client->draggableRegionsChanged();

}

-void ChromeClientImpl::didAssociateFormControls(const HeapVector<Member<Element>>& elements, LocalFrame* frame)

+void ChromeClientImpl::didAssociateFormControls(LocalFrame* frame)

{

WebLocalFrameImpl* webframe = WebLocalFrameImpl::fromFrame(frame);

if (webframe->autofillClient())

- webframe->autofillClient()->didAssociateFormControls(elements);

+ webframe->autofillClient()->didAssociateFormControls();

}

void ChromeClientImpl::didCancelCompositionOnSelectionChange()