Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: src/log.cc

Issue 2189513002: Move SimulatorHelper into V8 out of profiler clients. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Update Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/profiler/cpu-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 83e2ae9f28a287b7260f0f641ab6df4675ae065b..b7a5507df3f14b07e00a0d156106726dca673cb0 100644
--- a/src/log.cc
+++ b/src/log.cc
@@ -645,15 +645,9 @@ class Ticker: public sampler::Sampler {
void SampleStack(const v8::RegisterState& state) override {
if (!profiler_) return;
-#if defined(USE_SIMULATOR)
- Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate());
- v8::RegisterState regs;
- if (!SimulatorHelper::FillRegisters(i_isolate, &regs)) return;
-#else
- const v8::RegisterState& regs = state;
-#endif
- v8::TickSample sample;
- sample.Init(isolate(), regs, v8::TickSample::kIncludeCEntryFrame, true);
+ Isolate* isolate = reinterpret_cast<Isolate*>(this->isolate());
+ TickSample sample;
+ sample.Init(isolate, state, TickSample::kIncludeCEntryFrame, true);
profiler_->Insert(&sample);
}
« no previous file with comments | « src/api.cc ('k') | src/profiler/cpu-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698