Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: src/profiler/tick-sample.h

Issue 2189513002: Move SimulatorHelper into V8 out of profiler clients. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address alph's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/profiler/tick-sample.h
diff --git a/src/profiler/tick-sample.h b/src/profiler/tick-sample.h
index c7c42e63a28d10f6216d68179989247814e17d16..2ce214dab89aab26bb6d990f1f6f7e8be88cf102 100644
--- a/src/profiler/tick-sample.h
+++ b/src/profiler/tick-sample.h
@@ -15,21 +15,12 @@ namespace internal {
class Isolate;
struct TickSample : public v8::TickSample {
- TickSample() : v8::TickSample() {}
void Init(Isolate* isolate, const v8::RegisterState& state,
- RecordCEntryFrame record_c_entry_frame, bool update_stats);
+ RecordCEntryFrame record_c_entry_frame, bool update_stats,
+ bool update_state = true);
base::TimeTicks timestamp;
};
-#if defined(USE_SIMULATOR)
-class SimulatorHelper {
- public:
- // Returns true if register values were successfully retrieved
- // from the simulator, otherwise returns false.
- static bool FillRegisters(Isolate* isolate, v8::RegisterState* state);
-};
-#endif // USE_SIMULATOR
-
} // namespace internal
} // namespace v8

Powered by Google App Engine
This is Rietveld 408576698