Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6347)

Unified Diff: blimp/engine/mojo/blob_channel_service.h

Issue 2189503004: BlobChannelService is modified to be Mojo Service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into bcs Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/app/blimp_content_browser_client.cc ('k') | blimp/engine/mojo/blob_channel_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/mojo/blob_channel_service.h
diff --git a/blimp/engine/mojo/blob_channel_service.h b/blimp/engine/mojo/blob_channel_service.h
index 83e06d9368f3da8d0e7d289732c81a28603a21fd..a137a0694087e56ab08a372acd940d50c251cd55 100644
--- a/blimp/engine/mojo/blob_channel_service.h
+++ b/blimp/engine/mojo/blob_channel_service.h
@@ -8,7 +8,7 @@
#include <string>
#include "blimp/engine/mojo/blob_channel.mojom.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
namespace blimp {
@@ -20,18 +20,16 @@ namespace engine {
// Runs on the browser process.
class BlobChannelService : public mojom::BlobChannel {
public:
+ // |blob_channel_sender| must outlive the Mojo connection.
+ explicit BlobChannelService(BlobChannelSender* blob_channel_sender);
+
~BlobChannelService() override;
// Factory method called by Mojo.
- static void Create(BlobChannelSender* blob_channel_sender,
- mojo::InterfaceRequest<mojom::BlobChannel> request);
+ // Binds |this| to the connection specified by |request|.
+ void BindRequest(mojo::InterfaceRequest<mojom::BlobChannel> request);
private:
- // Creates a BlobChannel bound to the connection specified by |request|.
- // |blob_channel_sender| must outlive the Mojo connection.
- BlobChannelService(BlobChannelSender* blob_channel_sender,
- mojom::BlobChannelRequest request);
-
// BlobChannel implementation.
void GetCachedBlobIds(
const GetCachedBlobIdsCallback& response_callback) override;
@@ -40,8 +38,7 @@ class BlobChannelService : public mojom::BlobChannel {
uint32_t size) override;
void DeliverBlob(const std::string& id) override;
- // Binds |this| and its object lifetime to a Mojo connection.
- mojo::StrongBinding<mojom::BlobChannel> binding_;
+ mojo::BindingSet<mojom::BlobChannel> bindings_;
// Sender object which will receive the blobs passed over the Mojo service.
BlobChannelSender* blob_channel_sender_;
« no previous file with comments | « blimp/engine/app/blimp_content_browser_client.cc ('k') | blimp/engine/mojo/blob_channel_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698