Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Issue 2189503002: Revert of remote-debugging-port for guest sessions. (Closed)

Created:
4 years, 4 months ago by achuithb
Modified:
4 years, 4 months ago
Reviewers:
emaxx
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of remote-debugging-port for guest sessions. (patchset #1 id:1 of https://codereview.chromium.org/2141303003/ ) Reason for revert: Speculative revert for crbug.com/631640 BUG=631640 Original issue's description: > remote-debugging-port for guest sessions. > > --remote-debugging-port flag is lost when guest sessions are started on > chromeos. > > BUG=None > > Committed: https://crrev.com/7268c3d1f3f991740f536d9680426251392b98e8 > Cr-Commit-Position: refs/heads/master@{#405633} TBR=emaxx@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=None Committed: https://crrev.com/f85dca4cad17e2a4464d9e6f722f44e1c8082a93 Cr-Commit-Position: refs/heads/master@{#408009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
achuithb
Created Revert of remote-debugging-port for guest sessions.
4 years, 4 months ago (2016-07-27 00:17:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189503002/1
4 years, 4 months ago (2016-07-27 00:18:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 01:31:04 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f85dca4cad17e2a4464d9e6f722f44e1c8082a93 Cr-Commit-Position: refs/heads/master@{#408009}
4 years, 4 months ago (2016-07-27 01:33:00 UTC) #10
achuithb
4 years, 4 months ago (2016-07-28 23:12:24 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2196463002/ by achuith@chromium.org.

The reason for reverting is: Problem is still happening, so this isn't
responsible..

Powered by Google App Engine
This is Rietveld 408576698