Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2189483002: ui/base/cocoa: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/base/cocoa: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=rsesek@chromium.org BUG=554600 Committed: https://crrev.com/3986a102dcd2e16aacb98b19b743a94e86f3aa20 Cr-Commit-Position: refs/heads/master@{#408193}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/base/cocoa/nscolor_additions.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-07-26 23:56:03 UTC) #1
Robert Sesek
lgtm
4 years, 4 months ago (2016-07-27 15:21:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189483002/1
4 years, 4 months ago (2016-07-27 17:47:08 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-27 18:31:19 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 18:32:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3986a102dcd2e16aacb98b19b743a94e86f3aa20
Cr-Commit-Position: refs/heads/master@{#408193}

Powered by Google App Engine
This is Rietveld 408576698