Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2189463003: Use smart pointer for CPDF_Form in CPDF_Annot. (Closed)

Created:
4 years, 4 months ago by jaepark
Modified:
4 years, 4 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use smart pointer for CPDF_Form in CPDF_Annot. CPDF_Annot owns CPDF_Form, so use std::unique_ptr for memory management. BUG=pdfium:518 Committed: https://pdfium.googlesource.com/pdfium/+/c279a3e1bd3da4e7f7504e438e6df8b7079027f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M core/fpdfdoc/cpdf_annot.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
jaepark
4 years, 4 months ago (2016-07-26 22:58:05 UTC) #2
Lei Zhang
lgtm
4 years, 4 months ago (2016-07-26 23:12:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189463003/1
4 years, 4 months ago (2016-07-27 00:01:08 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 00:01:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/c279a3e1bd3da4e7f7504e438e6df8b70790...

Powered by Google App Engine
This is Rietveld 408576698