Issue 2189423002: Revert "Try again to flip official win builders to GN."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2189423002: Revert "Try again to flip official win builders to GN." (Closed)

Created:
4 years, 4 months ago by Dirk Pranke

Modified:
4 years, 4 months ago

Reviewers:
Sébastien Marchand

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2811

Target Ref:
refs/pending/branch-heads/2811

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "Try again to flip official win builders to GN." It looks like the syzygy build is still incorrect :(. (merge back to branch 2811). TBR=sebmarchand@chromium.org BUG=632566, 623659 Review-Url: https://codereview.chromium.org/2195713003 Cr-Commit-Position: refs/heads/master@{#408679}

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -18 lines)			Patch
	M	tools/mb/mb_config.pyl	View		6 chunks	+18 lines, -18 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dirk Pranke

4 years, 4 months ago (2016-07-31 20:55:10 UTC) #1

Description was changed from

==========
Revert "Try again to flip official win builders to GN."

It looks like the syzygy build is still incorrect :(.

(merge back to branch 2811).

TBR=sebmarchand@chromium.org
BUG=632566, 623659

Review-Url: https://codereview.chromium.org/2195713003
Cr-Commit-Position: refs/heads/master@{#408679}
==========

to

==========
Revert "Try again to flip official win builders to GN."

It looks like the syzygy build is still incorrect :(.

(merge back to branch 2811).

TBR=sebmarchand@chromium.org
BUG=632566, 623659

Review-Url: https://codereview.chromium.org/2195713003
Cr-Commit-Position: refs/heads/master@{#408679}
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages