Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2189413002: Update WebAPK metadata namespace. (Closed)

Created:
4 years, 4 months ago by Xi Han
Modified:
4 years, 4 months ago
Reviewers:
pkotwicz, gone
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update WebAPK metadata namespace. This updates the ManifestUpdateDetector after CL (https://codereview.chromium.org/2193683003/) landed. BUG=631063 Committed: https://crrev.com/be7abc45ee7d4512a18640924b0ce9de9c0dc6aa Cr-Commit-Position: refs/heads/master@{#408769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Xi Han
Hi Peter, could you please take a look? Thanks!
4 years, 4 months ago (2016-07-29 18:09:30 UTC) #2
pkotwicz
LGTM Thank you for making the change!
4 years, 4 months ago (2016-07-29 18:11:10 UTC) #3
Xi Han
dfalcantara@: could you please take a look? Thanks!
4 years, 4 months ago (2016-07-29 19:45:42 UTC) #5
gone
Need bug number attached.
4 years, 4 months ago (2016-07-29 20:47:07 UTC) #6
gone
lgtm after adding bug number.
4 years, 4 months ago (2016-07-29 20:47:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189413002/1
4 years, 4 months ago (2016-07-29 20:49:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-29 21:28:31 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 21:31:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be7abc45ee7d4512a18640924b0ce9de9c0dc6aa
Cr-Commit-Position: refs/heads/master@{#408769}

Powered by Google App Engine
This is Rietveld 408576698