Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/buildbot_spec.py

Issue 2189393002: Stop running nanobench on Test.*Debug bots (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix upload_perf_results Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # 1 #
2 # Copyright 2015 Google Inc. 2 # Copyright 2015 Google Inc.
3 # 3 #
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 # 6 #
7 7
8 #!/usr/bin/env python 8 #!/usr/bin/env python
9 9
10 usage = ''' 10 usage = '''
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
304 else: 304 else:
305 configuration = builder_dict.get( 305 configuration = builder_dict.get(
306 'configuration', CONFIG_DEBUG) 306 'configuration', CONFIG_DEBUG)
307 arch = (builder_dict.get('arch') or builder_dict.get('target_arch')) 307 arch = (builder_dict.get('arch') or builder_dict.get('target_arch'))
308 if ('Win' in builder_dict.get('os', '') and arch == 'x86_64'): 308 if ('Win' in builder_dict.get('os', '') and arch == 'x86_64'):
309 configuration += '_x64' 309 configuration += '_x64'
310 rv['configuration'] = configuration 310 rv['configuration'] = configuration
311 if configuration == CONFIG_COVERAGE: 311 if configuration == CONFIG_COVERAGE:
312 rv['do_compile_steps'] = False 312 rv['do_compile_steps'] = False
313 rv['do_test_steps'] = role == builder_name_schema.BUILDER_ROLE_TEST 313 rv['do_test_steps'] = role == builder_name_schema.BUILDER_ROLE_TEST
314 rv['do_perf_steps'] = (role == builder_name_schema.BUILDER_ROLE_PERF or 314 rv['do_perf_steps'] = role == builder_name_schema.BUILDER_ROLE_PERF
315 (role == builder_name_schema.BUILDER_ROLE_TEST and
316 configuration == CONFIG_DEBUG))
317 if rv['do_test_steps'] and 'Valgrind' in builder_name:
318 rv['do_perf_steps'] = True
319 if 'GalaxyS4' in builder_name:
320 rv['do_perf_steps'] = False
321 315
322 rv['build_targets'] = build_targets_from_builder_dict( 316 rv['build_targets'] = build_targets_from_builder_dict(
323 builder_dict, rv['do_test_steps'], rv['do_perf_steps']) 317 builder_dict, rv['do_test_steps'], rv['do_perf_steps'])
324 318
325 # Do we upload perf results? 319 # Do we upload perf results?
326 upload_perf_results = False 320 upload_perf_results = False
327 if role == builder_name_schema.BUILDER_ROLE_PERF: 321 if (role == builder_name_schema.BUILDER_ROLE_PERF and
322 CONFIG_RELEASE in configuration):
328 upload_perf_results = True 323 upload_perf_results = True
329 rv['upload_perf_results'] = upload_perf_results 324 rv['upload_perf_results'] = upload_perf_results
330 325
331 # Do we upload correctness results? 326 # Do we upload correctness results?
332 skip_upload_bots = [ 327 skip_upload_bots = [
333 'ASAN', 328 'ASAN',
334 'Coverage', 329 'Coverage',
335 'MSAN', 330 'MSAN',
336 'TSAN', 331 'TSAN',
337 'UBSAN', 332 'UBSAN',
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 if len(sys.argv) == 2 and sys.argv[1] == 'test': 403 if len(sys.argv) == 2 and sys.argv[1] == 'test':
409 self_test() 404 self_test()
410 sys.exit(0) 405 sys.exit(0)
411 406
412 if len(sys.argv) != 3: 407 if len(sys.argv) != 3:
413 print usage 408 print usage
414 sys.exit(1) 409 sys.exit(1)
415 410
416 with open(sys.argv[1], 'w') as out: 411 with open(sys.argv[1], 'w') as out:
417 json.dump(get_builder_spec(sys.argv[2]), out) 412 json.dump(get_builder_spec(sys.argv[2]), out)
OLDNEW
« no previous file with comments | « tools/buildbot_spec.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698