Sent feedback reports must respect the product ID if any was provided

chrome/browser/resources/feedback/js/feedback.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @type {string}
  * @const
  */
 var FEEDBACK_LANDING_PAGE =
     'https://support.google.com/chrome/go/feedback_confirmation';
 
@@ skipping 186 matching lines @@
     feedbackInfo.traceId = null;
   }
 </if>
 
   feedbackInfo.sendHistograms = useHistograms;
 
   // If the user doesn't want to send the screenshot.
   if (!$('screenshot-checkbox').checked)
     feedbackInfo.screenshot = null;
 
+  var productId = parseInt('' + feedbackInfo.productId);
+  if (isNaN(productId)) {
+    // For apps that still use a string value as the |productId|, we must clear

[Devlin, 2016/08/03 18:04:36]

Which apps are these?  Do they all go through this flow?  It looks like there
are some whitelisted apps for feedback private, so if any of them aren't
updated, the idl change will break them.

[afakhry, 2016/08/03 20:16:10]

For the whitelisted apps, I sent an alert email to the owners of these apps to
inform them of this change. I forwarded that email to you as FYI.

[Devlin, 2016/08/03 22:11:50]

Awesome, thanks!

+    // that value since the API uses an integer value, and a conflict in data
+    // types will cause the report to fail to be sent.
+    productId = null;
+  }
+  feedbackInfo.productId = productId;
+
   // Request sending the report, show the landing page (if allowed), and close
   // this window right away. The FeedbackRequest object that represents this
   // report will take care of sending the report in the background.
   sendFeedbackReport(useSystemInfo);
   if (feedbackInfo.flow != FeedbackFlow.LOGIN)
     window.open(FEEDBACK_LANDING_PAGE, '_blank');
   window.close();
   return true;
 }
 
@@ skipping 230 matching lines @@
     $('cancel-button').onclick = cancel;
     $('remove-attached-file').onclick = clearAttachedFile;
 <if expr="chromeos">
     $('performance-info-checkbox').addEventListener(
         'change', performanceFeedbackChanged);
 </if>
   });
 }
 
 initialize();