Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2189343002: [build] Port using prebuilt instrumented libraries for msan (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
Michael Achenbach, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Port using prebuilt instrumented libraries for msan BUG=chromium:631979 NOTRY=true Committed: https://crrev.com/5ef69e93a2abb48a515cff428b21684a6cae47c4 Cr-Commit-Position: refs/heads/master@{#38197}

Patch Set 1 #

Patch Set 2 : Port mb config #

Patch Set 3 : Fixes #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M DEPS View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M gypfiles/standalone.gypi View 1 2 4 chunks +14 lines, -0 lines 1 comment Download
M infra/mb/mb_config.pyl View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL. Come c/p from chromium's configs to get parity with chromium gyp regarding msan before ...
4 years, 4 months ago (2016-08-01 09:31:53 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-01 09:35:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189343002/40001
4 years, 4 months ago (2016-08-01 09:39:34 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-01 09:41:17 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 09:43:27 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5ef69e93a2abb48a515cff428b21684a6cae47c4
Cr-Commit-Position: refs/heads/master@{#38197}

Powered by Google App Engine
This is Rietveld 408576698