Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2189323002: [gn] Add missing deps and blacklist for msan (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Add missing dep and blacklist for msan Required for https://codereview.chromium.org/2194823002/ BUG=chromium:631979 NOTRY=true Committed: https://crrev.com/dc78fefb152ec5adab1f4d96734d2633a84a69c4 Cr-Commit-Position: refs/heads/master@{#38161}

Patch Set 1 #

Patch Set 2 : + Blacklist file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, --1 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + tools/msan/blacklist.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Michael Achenbach
PTAL. This is required in msan builds with GN: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/9930/steps/generate_build_files%20with%20gn%20%28fyi%29/logs/stdio
4 years, 4 months ago (2016-07-29 07:46:57 UTC) #4
Michael Achenbach
And requires a blacklist file as well: https://build.chromium.org/p/tryserver.v8/builders/v8_linux64_msan_rel/builds/129/steps/compile/logs/stdio
4 years, 4 months ago (2016-07-29 07:50:26 UTC) #5
vogelheim
lgtm
4 years, 4 months ago (2016-07-29 08:50:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2189323002/20001
4 years, 4 months ago (2016-07-29 08:55:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-07-29 08:59:32 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-07-29 09:01:29 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc78fefb152ec5adab1f4d96734d2633a84a69c4
Cr-Commit-Position: refs/heads/master@{#38161}

Powered by Google App Engine
This is Rietveld 408576698